Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Feb 2012 21:45:21 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r232271 - head/sys/kern
Message-ID:  <201202282145.q1SLjLpO093657@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Tue Feb 28 21:45:21 2012
New Revision: 232271
URL: http://svn.freebsd.org/changeset/base/232271

Log:
  Change definition of pipe_chmod() from K&R to C99, to avoid the
  following clang warning:
  
  sys/kern/sys_pipe.c:1556:10: error: promoted type 'int' of K&R function parameter is not compatible with the parameter type 'mode_t'
        (aka 'unsigned short') declared in a previous prototype [-Werror]
          mode_t mode;
                 ^
  sys/kern/sys_pipe.c:155:19: note: previous declaration is here
  static fo_chmod_t       pipe_chmod;
                          ^

Modified:
  head/sys/kern/sys_pipe.c

Modified: head/sys/kern/sys_pipe.c
==============================================================================
--- head/sys/kern/sys_pipe.c	Tue Feb 28 21:43:29 2012	(r232270)
+++ head/sys/kern/sys_pipe.c	Tue Feb 28 21:45:21 2012	(r232271)
@@ -1551,11 +1551,7 @@ pipe_close(fp, td)
 }
 
 static int
-pipe_chmod(fp, mode, active_cred, td)
-	struct file *fp;
- 	mode_t mode;
-	struct ucred *active_cred;
-	struct thread *td;
+pipe_chmod(struct file *fp, mode_t mode, struct ucred *active_cred, struct thread *td)
 {
 	struct pipe *cpipe;
 	int error;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201202282145.q1SLjLpO093657>