From owner-freebsd-ports@FreeBSD.ORG Fri Mar 28 02:18:55 2008 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA0DE106566C for ; Fri, 28 Mar 2008 02:18:55 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx24.fluidhosting.com [204.14.89.7]) by mx1.freebsd.org (Postfix) with SMTP id 2AC308FC14 for ; Fri, 28 Mar 2008 02:18:54 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 24806 invoked by uid 399); 28 Mar 2008 02:25:26 -0000 Received: from localhost (HELO ?192.168.0.5?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 28 Mar 2008 02:25:26 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <47EC5589.7070207@FreeBSD.org> Date: Thu, 27 Mar 2008 19:18:49 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Roman Divacky References: <1206548309.78560.69.camel@pav.hide.vol.cz> <20080326201416.GA34807@freebsd.org> In-Reply-To: <20080326201416.GA34807@freebsd.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: soralx@cydem.org, Pav Lucistnik , freebsd-ports@FreeBSD.org Subject: Re: [patch] pkg_delete(1) speedup X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Mar 2008 02:18:55 -0000 Roman Divacky wrote: > On Wed, Mar 26, 2008 at 05:18:29PM +0100, Pav Lucistnik wrote: >> You might have noticed a thread on the mailing list called "ports system >> woes". The submitter pointed out an inefficiency in pkg_delete routine, >> that parses the whole /var/db/pkg over and over again for every >> dependency of a package being removed. >> >> Attached is a patch by rdivacky that implements the idea of looking up >> all the values in a single pass over /var/db/pkg content. > > I hacked a slightly better patch that coveres a part of pkg_add too.. > > please review/test on: > > www.vlakno.cz/~rdivacky/pkg_tools.patch > > comments, benchmarks more than welcome! A) this is massively cool stuff, thanks for taking this on. :) B) you should probably do two versions of the patch, one with style(9)-only changes, and one without. The former makes it much easier to review the actual changes, and would speed your path to getting it in the tree. Doug -- This .signature sanitized for your protection