Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Jan 2007 10:06:01 -0500
From:      Thomas Dickey <dickey@radix.net>
To:        FreeBSD Current <freebsd-current@freebsd.org>
Subject:   Re: [CFT] ncurses update
Message-ID:  <20070106150601.GA6157@saltmine.radix.net>
In-Reply-To: <20070106142123.GA93898@nagual.pp.ru>
References:  <6eb82e0701060050s2a28d307m199ccfe0924e1a9@mail.gmail.com> <20070106142123.GA93898@nagual.pp.ru>

next in thread | previous in thread | raw e-mail | index | archive | help

--OgqxwSJOaUobr8KG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 06, 2007 at 05:21:23PM +0300, Andrey Chernov wrote:
> On Sat, Jan 06, 2007 at 04:50:30PM +0800, Rong-en Fan wrote:
> > http://people.freebsd.org/~rafan/ncurses/ncurses-5.6-fbsd7-20070106.dif=
f.gz
>=20
> In our code
>=20
>  (*tok =3D=3D '\0' || *tok =3D=3D '\\' || !isgraph(*tok)))
>=20
> must be
>=20
>  (*tok =3D=3D '\0' || *tok =3D=3D '\\' || !isgraph(UChar(*tok))))
>=20
> BTW, why our glue is ever needed? I see ncurses already is able to use=20
> cgetent. Not sure about proper TERMPATH and isetuid handling.

Discounting some code that was removed by editing where an ifdef would
have worked, there's a small change to use one of the FreeBSD-specific
functions, e.g.,

	/* For safety */
	if (issetugid())
		strcpy(pathbuf, _PATH_DEF_SEC);

That's all I recall from doing a diff last summer.  I don't recall
any issues with $TERMPATH per se.

--=20
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net

--OgqxwSJOaUobr8KG
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (SunOS)
Comment: For info see http://www.gnupg.org

iD8DBQFFn7rRtIqByHxlDocRAjdyAJwLP97zsOR4Jjk/WlSTrcqGFG1MeACfcq4x
rBxeilxqV77+z2QNva2eTD8=
=82Fp
-----END PGP SIGNATURE-----

--OgqxwSJOaUobr8KG--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070106150601.GA6157>