From owner-freebsd-ports@FreeBSD.ORG  Fri Jul 22 02:40:15 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5CADD16A431
	for <ports@freebsd.org>; Fri, 22 Jul 2005 02:40:15 +0000 (GMT)
	(envelope-from pauls@utdallas.edu)
Received: from mail.stovebolt.com (mail.stovebolt.com [66.221.101.248])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C06B643D72
	for <ports@freebsd.org>; Fri, 22 Jul 2005 02:40:09 +0000 (GMT)
	(envelope-from pauls@utdallas.edu)
Received: from [192.168.2.101] (adsl-66-137-148-66.dsl.rcsntx.swbell.net
	[66.137.148.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.stovebolt.com (Postfix) with ESMTP id 7845C3FC41
	for <ports@freebsd.org>; Thu, 21 Jul 2005 21:40:04 -0500 (CDT)
Date: Thu, 21 Jul 2005 21:39:44 -0500
From: Paul Schmehl <pauls@utdallas.edu>
To: ports@freebsd.org
Message-ID: <04AB93A9833EB439696DFBDF@Paul-Schmehls-Computer.local>
X-Mailer: Mulberry/4.0.0 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Cc: 
Subject: Strange portlint error
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Paul Schmehl <pauls@utdallas.edu>
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2005 02:40:15 -0000

I just ran portlint on a new port I'm working on, and I got the following 
error:

portlint -N
WARN: Makefile: COMMENT should begin with a capital, and end without a 
period
0 fatal errors and 1 warnings found.

Here's the comment:

COMMENT=        Squil is a network security management program.

As you can see, it has a period.  If I remove the period, portlint returns 
"looks fine".

Line 2054 of portlint reads:

if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { 
#"

It should be:

if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || ($makevar{COMMENT} !~ m/\.$/)) { 
#"

This patch will fix it:

--- portlint.orig       Thu Jul 21 21:40:24 2005
+++ portlint    Thu Jul 21 21:38:46 2005
@@ -2050,7 +2050,7 @@
                &perror("WARN: $file: unless this is a master port, COMMENT 
has to be set by \"=\", ".
                        "not by \"$1=\".") unless ($masterport);
        } else { # check for correctness
-               if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || 
($makevar{COMMENT} =~ m/\.$/)) { #"
+               if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || 
($makevar{COMMENT} !~ m/\.$/)) { #"
                        &perror("WARN: $file: COMMENT should begin with a 
capital, and end without a period");
                } elsif (length($makevar{COMMENT}) > 70) {
                        &perror("WARN: $file: COMMENT exceeds 70 characters 
limit.");

Paul Schmehl (pauls@utdallas.edu)
Adjunct Information Security Officer
University of Texas at Dallas
AVIEN Founding Member
http://www.utdallas.edu/