From owner-freebsd-hackers@FreeBSD.ORG Mon Jul 15 15:33:04 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id C1AD9F0B for ; Mon, 15 Jul 2013 15:33:04 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-qa0-x233.google.com (mail-qa0-x233.google.com [IPv6:2607:f8b0:400d:c00::233]) by mx1.freebsd.org (Postfix) with ESMTP id 88F36369 for ; Mon, 15 Jul 2013 15:33:04 +0000 (UTC) Received: by mail-qa0-f51.google.com with SMTP id f11so1657223qae.3 for ; Mon, 15 Jul 2013 08:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=y07o6dhG3q0ESnqRI59eKRYeEpVuL8G1AJZZnsyMZK0=; b=MNNTcfmM0ADbjHTASWCcxycwzpiSNqOFVWwdkggqgIEr/3LyAatJFzDtFnCAgp2HP7 Mh/KEVUanHynuQAtanB2WK3VgFLz+c6Xl1fTW9hBxs/PNdLL2AaNftJ0FifAyECCMFbA 25ZtQNxE9GoFOF8CqyILVpVha2cFZvrrYJQuVCMWYy9fJjSSFGAIz9gzqoqIgbDjJ4Ca EMn0BLEjDo8o5Cgk8H6rEsghsjXCVBfKIR18jmu1qXLAD9wYvpU3acHtnkgNngzYqHbL JDuhnuU6TTyd6cdVelZrrY/3ymr2BbxzBFGuO9xhcK8uBKgLr2uDeMr5d4Z8bpr3OV0Y VuRw== MIME-Version: 1.0 X-Received: by 10.229.179.200 with SMTP id br8mr12109768qcb.9.1373902384028; Mon, 15 Jul 2013 08:33:04 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.49.37.226 with HTTP; Mon, 15 Jul 2013 08:33:03 -0700 (PDT) In-Reply-To: References: Date: Mon, 15 Jul 2013 09:33:03 -0600 X-Google-Sender-Auth: R3je7vdYCxa7WsHPhHWoeRMDxU8 Message-ID: Subject: Re: GPT issues with device path lengths involving make_dev_physpath_alias From: Alan Somers To: Selphie Keller Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2013 15:33:04 -0000 It's a compatibility problem. If you change that constant, then any binaries built with the old value will break if they rely on it having a fixed value in a system or library call. For example, the MFIIO_QUERY_DISK ioctl in the mfi(4) driver passes a structure with an array of size SPECNAMELEN + 1. If you change SPECNAMELEN, then you'll have to add a compatibility mechanism for this ioctl. I'm sure there are other places that would have the same problem. Happy Hacking. On Sun, Jul 14, 2013 at 11:50 PM, Selphie Keller wrote: > hello hackers, > > I recently ran into a issue with a storage server that has some of the > drives in gpt vs mbr, tracked it down to a 64 char limit that is preventing > aliases in function make_dev_physpath_alias. I was curious if there was any > reason why this couldn't be bumped from 64 to 128 which would make room for > the device paths of gpt roughly around 94 and 96 chars long. > > - #define SPECNAMELEN > 63 > */* max length of devicename */ > + *#define SPECNAMELEN > 127 > */* max length of devicename */* > > > http://fxr.watson.org/fxr/source/sys/param.h#L106 > > Jul 14 22:10:17 fbsd9 kernel: make_dev_physpath_alias: WARNING - Unable to > alias gptid/4d177c56-ce17-26e3-843e-9c8a9faf1e0f to enc@n5003048000ba7d7d > /type@0/slot@b/elmdesc@Slot_11/gptid/4d177c56-ce17-26e3-843e-9c8a9faf1e0f - > path too long > Jul 14 22:10:17 fbsd9 kernel: make_dev_physpath_alias: WARNING - Unable to > alias gptid/4b1caf38-d967-24ee-c3a0-badff404e7ed to enc@n5003048000ba7d7d > /type@0/slot@5/elmdesc@Slot_05/gptid/4b1caf38-d967-24ee-c3a0-badff404e7ed - > path too long > > -Selphie (Estella Mystagic) > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"