From owner-cvs-src@FreeBSD.ORG Sun Feb 24 12:22:08 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A49E16A406 for ; Sun, 24 Feb 2008 12:22:08 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 9940213C461 for ; Sun, 24 Feb 2008 12:22:07 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 89414 invoked from network); 24 Feb 2008 11:37:35 -0000 Received: from localhost (HELO [127.0.0.1]) ([127.0.0.1]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 24 Feb 2008 11:37:35 -0000 Message-ID: <47C1616F.5040603@freebsd.org> Date: Sun, 24 Feb 2008 13:22:07 +0100 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.14 (Windows/20071210) MIME-Version: 1.0 To: Robert Watson References: <200802240007.m1O071xr052282@repoman.freebsd.org> <20080224110613.X25292@fledge.watson.org> In-Reply-To: <20080224110613.X25292@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Colin Percival Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Feb 2008 12:22:08 -0000 Robert Watson wrote: > On Sun, 24 Feb 2008, Colin Percival wrote: > >> cperciva 2008-02-24 00:07:00 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern uipc_syscalls.c >> Log: >> After finishing sending file data in sendfile(2), don't forget to send >> the provided trailers. This has been broken since revision 1.240. > > Nice work tracking this down -- it sounds like the perfect candidate for > a regression test. Over the last year or two, we've been working hard > to populate src/tools/regression/sockets with various test cases, and it > sounds like the sendfile tests there could use some fleshing out, since > we've now seen several rather significant functional regressions over > the last few years. Any chance we can get you to take a look at doing > that as well? :-) Writing a regression test should be my task as I'm the one who broke the stuff with rev 1.240. I'll whip something up over the next week. -- Andre