From owner-freebsd-isdn Fri Aug 30 4:11:50 2002 Delivered-To: freebsd-isdn@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD16D37B400 for ; Fri, 30 Aug 2002 04:11:48 -0700 (PDT) Received: from mailout08.sul.t-online.com (mailout08.sul.t-online.com [194.25.134.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AB0643E84 for ; Fri, 30 Aug 2002 04:11:48 -0700 (PDT) (envelope-from garyj@jennejohn.org) Received: from fwd07.sul.t-online.de by mailout08.sul.t-online.com with smtp id 17kjgn-00032q-08; Fri, 30 Aug 2002 13:11:45 +0200 Received: from peedub.jennejohn.org (520017439985-0001@[217.235.112.7]) by fmrl07.sul.t-online.com with esmtp id 17kjgZ-20MVMWC; Fri, 30 Aug 2002 13:11:31 +0200 Received: from peedub.jennejohn.org (localhost [127.0.0.1]) by peedub.jennejohn.org (8.12.5/8.11.6) with ESMTP id g7UBBUQI005381; Fri, 30 Aug 2002 13:11:31 +0200 (CEST) (envelope-from garyj@peedub.jennejohn.org) Message-Id: <200208301111.g7UBBUQI005381@peedub.jennejohn.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.3 To: hselasky@c2i.net Cc: freebsd-isdn@freebsd.org Subject: Re: New ihfc driver Reply-To: Gary Jennejohn In-reply-to: Your message of "Fri, 23 Aug 2002 14:51:02 +0200." <20020823125105.EQHE29728.fep01-svc.swip.net@mta-int.swip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 30 Aug 2002 13:11:30 +0200 From: Gary Jennejohn X-Sender: 520017439985-0001@t-dialin.net Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org hselasky@c2i.net writes: > I've been working on a new driver for > i4b supporting some (new) cards. The driver does not include DOV support, > and if there has been any other commits this summer (after MAY) I > would be glad if someone could make and send me patches against > my driver. Please see attachment for more information. > I like some of the stuff you've done, like clearly differentiating between layer 0 and layer 1 devices. Also, the cleanups of some of macros and coalescing some routines is good. The stuff you did in the state machines I can't comment on. The weird dynamic goto's and opaque macros which you use in your drivers are IMO not acceptable. If no-one but you understands this stuff then we'll have a maintenace nightmare. What if you get hit by a truck ? --- Gary Jennejohn / garyj@jennejohn.org gj@freebsd.org gj@denx.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message