Date: Mon, 15 Jun 2015 10:04:51 -0600 From: Warner Losh <imp@bsdimp.com> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: [rfc] add MK_TELNET_SSL as a build option Message-ID: <14F5785C-E07D-4573-8659-AFBB90271B3F@bsdimp.com> In-Reply-To: <CAJ-VmomwHuoTQV4cKjivbotn0iAec-=-Nnma10NnwCo54Gw_KQ@mail.gmail.com> References: <CAJ-VmomwHuoTQV4cKjivbotn0iAec-=-Nnma10NnwCo54Gw_KQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_7C768891-0016-4C56-BA5A-C605A3656658
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
> On Jun 13, 2015, at 4:40 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> I'd appreciate feedback here as it does involve addin ga new MK, and I
> really dislike it. :(
Me too. However, in this case it seems necessary. You need to have a =
system
with SSL, but without SSL telnet. Perhaps, though, you on=E2=80=99t =
really need telnet
at all on these boxes?
> -.if ${MK_OPENSSL} !=3D "no"
> +.if ${MK_OPENSSL} !=3D "no" && ${MK_TELNET_SSL} !=3D =E2=80=9Cno=E2=80=9D=
...
> -.if ${MK_OPENSSL} !=3D "no"
> +.if ${MK_OPENSSL} !=3D "no" && ${MK_TELNET_SSL} !=3D =E2=80=9Cno"
etc
If MK_OPENSSL is =E2=80=9Cno=E2=80=9D, then MK_TELNET_SSL is necessarily =
no.
Reduce this to just testing for that.
> .if ${MK_CRYPT} =3D=3D "no"
> MK_OPENSSL:=3D no
> +MK_TELNET_SSL:=3D no
> MK_OPENSSH:=3D no
> MK_KERBEROS:=3D no
The last two (now three) are redunant because they are handled
below with the OPENSSL dependency.
> .endif
> @@ -312,6 +314,7 @@
> .endif
>=20
> .if ${MK_OPENSSL} =3D=3D "no"
> +MK_TELNET_SSL:=3D no
> MK_OPENSSH:=3D no
> MK_KERBEROS:=3D no
> .endif
here...
Warner
--Apple-Mail=_7C768891-0016-4C56-BA5A-C605A3656658
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJVfvekAAoJEGwc0Sh9sBEAYbUQAKdjMEdqVtyWXzFMrCX4BMb6
UcoyYeNUan7szMhFIAbfAHe3jKlWFsPhDAcnRgxp8hH+Yo3/m06HW+Pjyx1V5ukm
HKFjLd/pF7AX7kWkRvWwAvYe6IwyhjyTSXr0oK7hx3b4AimHCP52kjKATDEUg1+1
ofn+FqCbVOsg9MH6Xj7GHNQ26sriZkWCuVayB+nSCMzUn2XMmQ3Bms8k5d02anSc
ix5AYr9/UpeD2NuwOjffYQ9ovXyg5eBamri4kXSipCs8sA/cmAw0/vH9i4nXpIVS
KQicr3vcfYTTmlpEMwJYu1cvyV/s/fNsRjm1mcJbGbaG7fC9NSdV16mgY4EYxXI3
TKOikB2eh1A2aAY3vSrD+AsbXyKYrzQIU3Bo8IlegGCPoBo7FscvncxZOzZ+69j9
YOj4J2jfzd2dvDkMR4MW6oXTxotZX5r09WQ4dE07s3HVqGQhSiMCU+TxQ2o+PMo+
HJo98kpwNophrXqnrHn4c319x+JrpFdyk535Wqry9gP2qy6K2BuM6gZ9ZwX2kw/H
5E6kA8j/AnKKyctnFQJEVQpKF5BalWfL2LcHh52CCOO9WY4GRAuCdj4ocJBb35rh
iVjLIuPmY70p0n7QraykK7AcwGcOUG9TmuDBblzbA1sVI42jX6uKQsBr8cwYwhrA
JF8kzf0ZQ1ZeCqQCHVbH
=5Dgc
-----END PGP SIGNATURE-----
--Apple-Mail=_7C768891-0016-4C56-BA5A-C605A3656658--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14F5785C-E07D-4573-8659-AFBB90271B3F>