From owner-freebsd-arch@FreeBSD.ORG Mon Jun 15 16:04:54 2015 Return-Path: Delivered-To: freebsd-arch@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8AE86BAF for ; Mon, 15 Jun 2015 16:04:54 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ie0-f175.google.com (mail-ie0-f175.google.com [209.85.223.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 563C11C3 for ; Mon, 15 Jun 2015 16:04:53 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by iecrd14 with SMTP id rd14so34130217iec.3 for ; Mon, 15 Jun 2015 09:04:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=lY/oJGvz5FGwIL0d24Hrldu2m6A5P2flScjk2L4bOVs=; b=FGwYvQHeWmXuV4KsCqbYae0QimvSUWAsczvHv6yM34tjLh7l8s9JHACXPLhNYeAzxW nlhBoLfiswQ404dAlHqW4kxrmVsaW9Gr8t4qYIZWqUHAisUT/7gMw2wvsZ7qXJW1QXrZ 11wwEXJjidwe9Qnh6krMQaHoS1agGO3UoxSpInFOWw75NRKv96J0nblOdeMkfjSe07bV XxBUFMrfy7rtjDjb/xyynmR0DJhkHPnnBZZq1FEbFjLDSk88vGHg9NkiU2RnIF6mEmDs 294lS0ZutsgZM6aRK3Cw1DvkYZk7PbYc49riMLd+pl5aoY6mjEfGuZHAOKkFWMy7Rbcv Qh0g== X-Gm-Message-State: ALoCoQmbiAuRqxs/tnv/hKyyiX0dfruAUED2Sj3cDloDYyEZuSAg3p+Brd29xzZzqaHhNh8ZA0fH X-Received: by 10.107.137.22 with SMTP id l22mr3606699iod.21.1434384293218; Mon, 15 Jun 2015 09:04:53 -0700 (PDT) Received: from netflix-mac-wired.bsdimp.com ([50.253.99.174]) by mx.google.com with ESMTPSA id z15sm6145735igp.12.2015.06.15.09.04.51 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 15 Jun 2015 09:04:52 -0700 (PDT) Sender: Warner Losh Subject: Re: [rfc] add MK_TELNET_SSL as a build option Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_7C768891-0016-4C56-BA5A-C605A3656658"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: Date: Mon, 15 Jun 2015 10:04:51 -0600 Cc: "freebsd-arch@freebsd.org" Message-Id: <14F5785C-E07D-4573-8659-AFBB90271B3F@bsdimp.com> References: To: Adrian Chadd X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 16:04:54 -0000 --Apple-Mail=_7C768891-0016-4C56-BA5A-C605A3656658 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 13, 2015, at 4:40 PM, Adrian Chadd wrote: > I'd appreciate feedback here as it does involve addin ga new MK, and I > really dislike it. :( Me too. However, in this case it seems necessary. You need to have a = system with SSL, but without SSL telnet. Perhaps, though, you on=E2=80=99t = really need telnet at all on these boxes? > -.if ${MK_OPENSSL} !=3D "no" > +.if ${MK_OPENSSL} !=3D "no" && ${MK_TELNET_SSL} !=3D =E2=80=9Cno=E2=80=9D= ... > -.if ${MK_OPENSSL} !=3D "no" > +.if ${MK_OPENSSL} !=3D "no" && ${MK_TELNET_SSL} !=3D =E2=80=9Cno" etc If MK_OPENSSL is =E2=80=9Cno=E2=80=9D, then MK_TELNET_SSL is necessarily = no. Reduce this to just testing for that. > .if ${MK_CRYPT} =3D=3D "no" > MK_OPENSSL:=3D no > +MK_TELNET_SSL:=3D no > MK_OPENSSH:=3D no > MK_KERBEROS:=3D no The last two (now three) are redunant because they are handled below with the OPENSSL dependency. > .endif > @@ -312,6 +314,7 @@ > .endif >=20 > .if ${MK_OPENSSL} =3D=3D "no" > +MK_TELNET_SSL:=3D no > MK_OPENSSH:=3D no > MK_KERBEROS:=3D no > .endif here... Warner --Apple-Mail=_7C768891-0016-4C56-BA5A-C605A3656658 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVfvekAAoJEGwc0Sh9sBEAYbUQAKdjMEdqVtyWXzFMrCX4BMb6 UcoyYeNUan7szMhFIAbfAHe3jKlWFsPhDAcnRgxp8hH+Yo3/m06HW+Pjyx1V5ukm HKFjLd/pF7AX7kWkRvWwAvYe6IwyhjyTSXr0oK7hx3b4AimHCP52kjKATDEUg1+1 ofn+FqCbVOsg9MH6Xj7GHNQ26sriZkWCuVayB+nSCMzUn2XMmQ3Bms8k5d02anSc ix5AYr9/UpeD2NuwOjffYQ9ovXyg5eBamri4kXSipCs8sA/cmAw0/vH9i4nXpIVS KQicr3vcfYTTmlpEMwJYu1cvyV/s/fNsRjm1mcJbGbaG7fC9NSdV16mgY4EYxXI3 TKOikB2eh1A2aAY3vSrD+AsbXyKYrzQIU3Bo8IlegGCPoBo7FscvncxZOzZ+69j9 YOj4J2jfzd2dvDkMR4MW6oXTxotZX5r09WQ4dE07s3HVqGQhSiMCU+TxQ2o+PMo+ HJo98kpwNophrXqnrHn4c319x+JrpFdyk535Wqry9gP2qy6K2BuM6gZ9ZwX2kw/H 5E6kA8j/AnKKyctnFQJEVQpKF5BalWfL2LcHh52CCOO9WY4GRAuCdj4ocJBb35rh iVjLIuPmY70p0n7QraykK7AcwGcOUG9TmuDBblzbA1sVI42jX6uKQsBr8cwYwhrA JF8kzf0ZQ1ZeCqQCHVbH =5Dgc -----END PGP SIGNATURE----- --Apple-Mail=_7C768891-0016-4C56-BA5A-C605A3656658--