From owner-freebsd-current@FreeBSD.ORG  Wed Nov  2 00:44:39 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D758916A41F
	for <current@freebsd.org>; Wed,  2 Nov 2005 00:44:38 +0000 (GMT)
	(envelope-from ambrisko@ambrisko.com)
Received: from mail.ambrisko.com (mail.ambrisko.com [64.174.51.43])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 887A943D45
	for <current@freebsd.org>; Wed,  2 Nov 2005 00:44:38 +0000 (GMT)
	(envelope-from ambrisko@ambrisko.com)
Received: from server2.ambrisko.com (HELO www.ambrisko.com) ([192.168.1.2])
	by mail.ambrisko.com with ESMTP; 01 Nov 2005 16:44:38 -0800
Received: from ambrisko.com (localhost [127.0.0.1])
	by www.ambrisko.com (8.12.11/8.12.9) with ESMTP id jA20ibR4041465;
	Tue, 1 Nov 2005 16:44:37 -0800 (PST)
	(envelope-from ambrisko@ambrisko.com)
Received: (from ambrisko@localhost)
	by ambrisko.com (8.12.11/8.12.11/Submit) id jA20ibXV041464;
	Tue, 1 Nov 2005 16:44:37 -0800 (PST) (envelope-from ambrisko)
From: Doug Ambrisko <ambrisko@ambrisko.com>
Message-Id: <200511020044.jA20ibXV041464@ambrisko.com>
In-Reply-To: <43680737.6080108@samsco.org>
To: Scott Long <scottl@samsco.org>
Date: Tue, 1 Nov 2005 16:44:37 -0800 (PST)
X-Mailer: ELM [version 2.4ME+ PL94b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: current@freebsd.org
Subject: Re: Rocket Port update patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Nov 2005 00:44:39 -0000

Scott Long writes:
| Doug Ambrisko wrote:
| > I've brought in the changes to the driver from the Comtrol web site.
| > This greatly improves the RocketPort HW support for those devices.
| > The changes are at:
| > 	http://www.ambrisko.com/doug/rp_current.patch
| > 
| > I'd like to commit it so things just work out of the box.  I tried to
| > maintain all the various FreeBSD & Comtrol changes.
| > 
| > It works here on my previously unsupported card.
| 
| One thing stands out on the brief skim.  Why on earth does the code need 
| to keep a global count of the number of adapters, and why does it bail 
| if there are more than 4 adapters?

I don't know.  Do we have a contact there to ask questions?  I don't have 
more then one 16 port adapter to see if there is a problem.

That brings up a point, we need to scope the functions and stuff so
they don't conflict with other stuff.  I kind-of hate to change
all the names to make it easier to merge in changes later.
Should we change all the sFlushRxFIFO type stuff to rp_s_flush_rx_fifo
and put the globals into the softc's?  Obviously they've put some
effort into supporting FreeBSD which is a good thing.  I don't know
how things go between them and us.

Thanks,

Doug A.