From owner-cvs-all Mon Mar 24 8: 6: 9 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E88237B401; Mon, 24 Mar 2003 08:06:06 -0800 (PST) Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id 420FA43FBD; Mon, 24 Mar 2003 08:06:05 -0800 (PST) (envelope-from nectar@celabo.org) Received: from madman.celabo.org (madman.celabo.org [10.0.1.111]) by gw.nectar.cc (Postfix) with ESMTP id C69CB69; Mon, 24 Mar 2003 10:06:04 -0600 (CST) Received: by madman.celabo.org (Postfix, from userid 1001) id B13CC78C43; Mon, 24 Mar 2003 10:06:04 -0600 (CST) Date: Mon, 24 Mar 2003 10:06:04 -0600 From: "Jacques A. Vidrine" To: Martin Blapp Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/isc-dhcp/client dhclient.c Message-ID: <20030324160604.GB1911@madman.celabo.org> References: <200303232329.h2NNTaI5089971@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200303232329.h2NNTaI5089971@repoman.freebsd.org> X-Url: http://www.celabo.org/ User-Agent: Mutt/1.5.3i-ja.1 X-Spam-Status: No, hits=-31.7 required=5.0 tests=AWL,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REFERENCES,REPLY_WITH_QUOTES,USER_AGENT_MUTT version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Mar 23, 2003 at 03:29:36PM -0800, Martin Blapp wrote: > mbr 2003/03/23 15:29:36 PST > > FreeBSD src repository > > Modified files: > contrib/isc-dhcp/client dhclient.c > Log: > We don't have cat(1) and kill(1) on the miniroot disks. > > This fix will be committed to the ISC repo later, but for now > take this file out of the vendor tree. > > Reviewed by: phk > Approved by: murray Are you sure that all values of pid_t can be represented in a signed int? + pid_t oldpid; ! e = fscanf(pidfd, "%d", &oldpid); I'd probably opt to do the fscanf with an unsigned long, and then cast the value to (pid_t). *shrug* Cheers, -- Jacques A. Vidrine http://www.celabo.org/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message