From owner-freebsd-current@freebsd.org Tue Jul 12 13:58:23 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF44CB92095 for ; Tue, 12 Jul 2016 13:58:23 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A3CCF1D6B for ; Tue, 12 Jul 2016 13:58:23 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (unknown [10.1.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 73F391F1B for ; Tue, 12 Jul 2016 13:58:21 +0000 (UTC) Subject: Re: Oversight in /etc/defaults/rc.conf To: freebsd-current@freebsd.org References: <20160712122732.GA5596@FreeBSD.org> From: Allan Jude Message-ID: Date: Tue, 12 Jul 2016 09:58:20 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160712122732.GA5596@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2016 13:58:23 -0000 On 2016-07-12 08:27, Glen Barber wrote: > On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote: >> I just upgraded my main machine to 11-STABLE. Things are mostly working >> fine -- however I did notice that the new iovctl rc script is apparently >> enabled by default. That seems like a trivial omission: >> >> Index: etc/defaults/rc.conf >> =================================================================== >> --- etc/defaults/rc.conf (revision 302482) >> +++ etc/defaults/rc.conf (working copy) >> @@ -695,6 +695,7 @@ >> rctl_enable="YES" # Load rctl(8) rules on boot >> rctl_rules="/etc/rctl.conf" # rctl(8) ruleset. See rctl.conf(5). >> >> +iovctl_enable="NO" >> iovctl_files="" # Config files for iovctl(8) >> >> ############################################################## >> > > I'm not sure I understand. Is there a functional and/or performance > impact with it enabled by default? (Note, I don't disable it in my > rc.conf, and there is no /dev/iov/* on my system.) > > Glen > If the service should be on by default, then it should have iovctl_enable="YES" in etc/defaults/rc.conf One way or the other, a default should be set. -- Allan Jude