From owner-freebsd-net@FreeBSD.ORG Tue Apr 19 12:11:45 2005 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 220AA16A4CE; Tue, 19 Apr 2005 12:11:45 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A50B43D41; Tue, 19 Apr 2005 12:11:44 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id j3JCBgCe066707 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 19 Apr 2005 16:11:43 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.1/8.12.8) with ESMTP id j3JCBguC006045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Apr 2005 16:11:42 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.1/8.13.1/Submit) id j3JCBgMQ006044; Tue, 19 Apr 2005 16:11:42 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 19 Apr 2005 16:11:41 +0400 From: Gleb Smirnoff To: Andre Oppermann , sam@FreeBSD.org Message-ID: <20050419121141.GB5862@cell.sick.ru> References: <20050419064747.GC734@cell.sick.ru> <4264D430.D39B81D0@freebsd.org> <20050419120324.GA5862@cell.sick.ru> <4264F4BC.4F3B57AE@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <4264F4BC.4F3B57AE@freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: ClamAV version devel-20050125, clamav-milter version 0.80ff on relay.bestcom.ru X-Virus-Status: Clean cc: net@FreeBSD.org Subject: Re: if_link_state_change() patch for review X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2005 12:11:45 -0000 On Tue, Apr 19, 2005 at 02:08:28PM +0200, Andre Oppermann wrote: A> Gleb Smirnoff wrote: A> > A> You have to be careful here indeed. If the link is rapidly flapping A> > A> then you only want to report changes in status. For example when A> > A> it going down, up, down and all these events got queued it doesn't A> > A> make sense to report down->down. This could indeed confuse some A> > A> tools and isn't very useful. Either you check the first event vs. A> > A> the last one if there is a change in state or you just take the events A> > A> as trigger to have a look at the interface status when the ithread A> > A> runs. There however you'd have to track the previous state to detect A> > A> changes. A> > A> > I do not know any applications which would be confused, yet. Also, while A> > event coalescing is possible theoretically, I failed to reproduce it. I've A> > added a debugging printf, so we will see if anyone experiences these A> > coalescing events at all. A> A> It doesn't really make sense, so we better don't do it and document A> that fact. Well, the printf won't hurt anyone. And it is really interesting if this is practically possible. [cc'ing Sam, since we together have came to that printf] -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE