Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Jun 2016 09:38:29 +0200
From:      Guido Falsi <madpilot@FreeBSD.org>
To:        Tijl Coosemans <tijl@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r416393 - in head: deskutils/tomboy devel/gmake devel/ocaml-deriving-ocsigen/files games/0ad/files
Message-ID:  <84c7bc7d-6e49-7924-7110-ba540e3cf6d5@FreeBSD.org>
In-Reply-To: <20160605203126.7677afc4@kalimero.tijl.coosemans.org>
References:  <201606051435.u55EZ2q0028696@repo.freebsd.org> <77ffae79-adc6-de80-c2bb-b874fe1852c4@FreeBSD.org> <20160605175316.7ab3eb30@kalimero.tijl.coosemans.org> <c5921d99-e3fb-9501-0116-6a2878c3685c@FreeBSD.org> <20160605203126.7677afc4@kalimero.tijl.coosemans.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 06/05/16 20:31, Tijl Coosemans wrote:
> On Sun, 5 Jun 2016 17:59:48 +0200 Guido Falsi <madpilot@FreeBSD.org> wrote:
>> On 06/05/16 17:53, Tijl Coosemans wrote:
>>> On Sun, 5 Jun 2016 16:40:51 +0200 Guido Falsi <madpilot@FreeBSD.org> wrote:
>>>> On 06/05/16 16:35, Tijl Coosemans wrote:
>>>>>   - games/0ad: disable make jobs when building bundled Spidermonkey.
>>>>
>>>> Thanks for spotting this!
>>>
>>> Actually I don't fully understand the problem.  Something about the
>>> combination of phony double-colon rules and multiple jobs breaks things.
>>> I'm not entirely convinced it's a Makefile bug.  It could be a gmake bug,
>>> but I haven't managed to reproduce it in a small test Makefile.
>>>
>>> I figured out a way to work around the first case in the Spidermonkey
>>> Makefiles (see patch 3 in the PR), but not the second so I just disabled
>>> make jobs.
>>
>> Interesting.
>>
>> I'll try to check if I can fix it myself in the next days.
> 
> r416413 seems to fix this as well.  I'll leave it to you to double check
> this and revert the change.
> 

Most probably it does fix it. Going to check soon.

Thanks again!

-- 
Guido Falsi <madpilot@FreeBSD.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?84c7bc7d-6e49-7924-7110-ba540e3cf6d5>