Date: Fri, 05 Oct 2012 13:32:07 -0400 From: Greg Larkin <glarkin@FreeBSD.org> To: Alex Dupre <ale@FreeBSD.org> Cc: gnome@FreeBSD.org, Joe Marcus Clarke <marcus@freebsd.org>, autotools@FreeBSD.org Subject: Re: charset.alias Message-ID: <506F1997.7090400@FreeBSD.org> In-Reply-To: <506F163F.4090403@FreeBSD.org> References: <506F01C4.6040704@FreeBSD.org> <506F0B56.6060208@FreeBSD.org> <506F163F.4090403@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/5/12 1:17 PM, Alex Dupre wrote: > Greg Larkin ha scritto: >> I worked out a slightly different patch to devel/patch this >> morning and just committed it. It already uses a construct for >> inlining the charset data for certain platforms when it shouldn't >> install the charset.alias file due to package conflicts. >> >> Let me know if you see any issues with that. > > I see at least one remaining issue, i.e. you included the wrong > charset.alias (not the correct one generated by libiconv). Anyway > I think that we should always use the shared charset.alias file > instead of hardcoding the mapping in every port. > Hi Alex, I included the charset.alias data generated by the devel/patch build itself (config.charset script, IIRC), and I followed the spirit of the existing code in the application in deciding to embed it within an #if/#endif block. Since I am no expert on charsets, libiconv or gettext, please feel free to replace my fix with your patch, if that's a better long-term solution. Thank you, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/cpucycle/ - Follow you, follow me -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBvGZcACgkQ0sRouByUApD+twCePABtm+d2g7G9JUG1fRPNm2CL y7EAoJvZInI35P+FbDp/RxVmIJ6lTntE =k9jB -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?506F1997.7090400>