Date: Mon, 10 Oct 2005 14:10:55 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Renato Botelho <garga@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/galaxyhack Makefile ports/games/galaxyhack/files patch-Makefile Message-ID: <20051010141055.GA17353@FreeBSD.org> In-Reply-To: <200510101327.j9ADRXJL014167@repoman.freebsd.org> References: <200510101327.j9ADRXJL014167@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 10, 2005 at 01:27:31PM +0000, Renato Botelho wrote:
> garga 2005-10-10 13:27:31 UTC
>
> FreeBSD ports repository
>
> Modified files:
> games/galaxyhack Makefile
> games/galaxyhack/files patch-Makefile
> Log:
> o Fix wrong patch in "files" directory and convert DOS to UNIX text files in
> post-extract.
CR/LF -> LF conversion is somewhat suboptimal: by doing -exec, find(1)
spawns ${REINPLACE_CMD} (and probably ${ECHO_CMD}, but this one is cheap
since it's a shell builtin) on every file it finds. Correct way would
be to use xargs(1), as mentioned in section ``4.4 Patching'' of Porter's
Handbook.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051010141055.GA17353>