From owner-svn-src-head@freebsd.org Tue Jul 14 17:31:58 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 47B983698F9; Tue, 14 Jul 2020 17:31:58 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B5nd95K1Vz4JtS; Tue, 14 Jul 2020 17:31:57 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id BC23D3C0199; Tue, 14 Jul 2020 17:31:51 +0000 (UTC) Date: Tue, 14 Jul 2020 17:31:51 +0000 From: Brooks Davis To: Adrian Chadd Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r363172 - head/contrib/bc/src Message-ID: <20200714173151.GB23830@spindle.one-eyed-alien.net> References: <202007140502.06E52IZn022859@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gj572EiMnwbLXET9" Content-Disposition: inline In-Reply-To: <202007140502.06E52IZn022859@repo.freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 4B5nd95K1Vz4JtS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 17:31:58 -0000 --gj572EiMnwbLXET9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2020 at 05:02:18AM +0000, Adrian Chadd wrote: > Author: adrian > Date: Tue Jul 14 05:02:18 2020 > New Revision: 363172 > URL: https://svnweb.freebsd.org/changeset/base/363172 >=20 > Log: > [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0. > =20 > I guess this didn't like the case statements.. ? But this does quieten > the compiler error. IMO it would be better to disable this warning for this (old) compiler on this file rather than making a change here (in general we should be removing these sorts of changes). That being said, we need to write down some guidance on this so we have a clear set of principles and we can figure out how we decided which compilers are on which side of the line. -- Brooks --gj572EiMnwbLXET9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJfDewGAAoJEKzQXbSebgfADhkIAIO5tY2875RqsG1Ci2JAX0AH /zhJ8Jl4YSH+4dtzngUopIErLyEiFnL49A/k4q/Fzc/9jxjwDHxGctFluaH2McJZ nPxo8RKJASw4Q/esZfUrVD/A9lkGnFCjUCZKweRphYHgXoq5cOdZMyqDLsfkGzcs sivYDV78BDwn6ygFJ2tQyuwIVg5WfAPR8gWu4cbPn30dYea1ZiV/tHWa8peCLgW2 EAl2/Y6z4Srn99znJl2ji8TqnNLWALLm9e7nJ9IlMG6m1stORws8NhNtriBY7PGZ s6qDWpnCIeRNv5M+AYkRZc1AgVkoNNdPdMLEG/qWa685fpqWTnJ9w3mO7ODhExc= =iDcv -----END PGP SIGNATURE----- --gj572EiMnwbLXET9--