Date: Sun, 7 Mar 2004 17:03:23 +0100 From: Ulrich Spoerlein <q@uni.de> To: Mark Linimon <linimon@lonesome.com> Cc: freebsd-ports@freebsd.org Subject: Re: New camserv-0.5.0 broken in 4-stable? Message-ID: <20040307160323.GA803@galgenberg.net> In-Reply-To: <Pine.LNX.4.44.0403041457410.17788-100000@pancho> References: <200403041524.KAA24937406@shell.TheWorld.com> <Pine.LNX.4.44.0403041457410.17788-100000@pancho>
next in thread | previous in thread | raw e-mail | index | archive | help
--gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, 04.03.2004 at 15:02:08 -0600, Mark Linimon wrote: > > Just updated to camserv-0.5.0 and when trying to use it with > > a bktr card I get the following: > > /usr/libexec/ld-elf.so.1: /usr/local/lib/camserv/libvideo_fbsd_bttv.so:= Undefined symbol "calculate_pic_mean" > > What's (not) happening here? > > It worked fine previously and fxtv works. > Hmm, I merely tested the compile and diffed the distfiles. > Running 'camserv' doesn't seem to produce this problem. > (I run fxtv on that machine, although honestly, I did not > test the binary before the commit). >=20 > I have Cc:ed the submitter of the PR that updated to 0.5.0 > to ask if the submitter can confirm this? >=20 > I have 4.9-PRERELEASE on the machine that did the compile > testing, if that matters. I already sent an Email two days ago, but it looks like it got stuck somewhere. Sorry if this appears twice. I took a look at the source code and found out, that the author forgot to rename calculate_pic_mean() to camserv_get_pic_mean(). There is also an off-by-one error in that function. Please use this patch, it works for me. There are two new files, patch-ac and patch-ad. I also fixed the configuration file from getting overwritten on re-install. Index: Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/multimedia/camserv/Makefile,v retrieving revision 1.8 diff -u -r1.8 Makefile --- Makefile 4 Mar 2004 06:54:21 -0000 1.8 +++ Makefile 5 Mar 2004 19:05:18 -0000 @@ -7,6 +7,7 @@ =20 PORTNAME=3D camserv PORTVERSION=3D 0.5.0 +PORTREVISION=3D 1 PORTEPOCH=3D 1 CATEGORIES=3D multimedia MASTER_SITES=3D http://cserv.sourceforge.net/old/ Index: pkg-plist =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/multimedia/camserv/pkg-plist,v retrieving revision 1.3 diff -u -r1.3 pkg-plist --- pkg-plist 4 Mar 2004 06:29:01 -0000 1.3 +++ pkg-plist 5 Mar 2004 19:05:18 -0000 @@ -28,7 +28,7 @@ lib/camserv/libvideo_fbsd_bttv.la lib/camserv/libvideo_fbsd_bttv.so lib/camserv/libvideo_fbsd_bttv.so.0 -share/camserv/camserv.cfg +share/camserv/camserv.cfg.dist share/camserv/defpage.html %%PORTDOCS%%%%DOCSDIR%%/README %%PORTDOCS%%%%DOCSDIR%%/javascript.txt --- /dev/null Fri Mar 5 20:02:02 2004 +++ files/patch-ac Fri Mar 5 20:02:00 2004 @@ -0,0 +1,13 @@ +--- camserv/video_fbsd_bttv.c.orig Fri Mar 5 19:22:31 2004 ++++ camserv/video_fbsd_bttv.c Fri Mar 5 19:41:16 2004 +@@ -644,8 +644,8 @@ + if( !fbttv_dev->autobright || --fbttv_dev->autoleft > 0 ) + return 0; +=20 +- totmean =3D calculate_pic_mean( width, height, picbuf, 1, 0, 0,=20 +- width, height ); ++ totmean =3D camserv_get_pic_mean( width, height, picbuf, 1, 0, 0,=20 ++ width-1, height-1 ); + if( totmean < (256 / 2) - 10 || totmean > (256 / 2) + 10 ) { + newbright =3D fbttv_dev->brightness; + if( totmean > (256 / 2) + 10 ){ --- /dev/null Fri Mar 5 20:02:02 2004 +++ files/patch-ad Fri Mar 5 20:02:00 2004 @@ -0,0 +1,12 @@ +--- Makefile.in.orig Fri Mar 5 19:11:47 2004 ++++ Makefile.in Fri Mar 5 19:12:04 2004 +@@ -96,3 +96,3 @@ +=20 +-data_DATA =3D camserv.cfg defpage.html ++data_DATA =3D camserv.cfg.dist defpage.html + EXTRA_DIST =3D camserv.cfg.in javascript.txt BUGS camserv.spec defpage.ht= ml +@@ -402,3 +402,3 @@ +=20 +-camserv.cfg: camserv.cfg.in ++camserv.cfg.dist: camserv.cfg.in + @sed -e s%CAMSERV_MODDIR%$(CAMSERV_MODDIR)%g < camserv.cfg.in > $@=20 Ulrich Spoerlein --=20 PGP Key ID: F0DB9F44 Get it while it's hot! PGP Fingerprint: F1CE D062 0CA9 ADE3 349B 2FE8 980A C6B5 F0DB 9F44 I abhor a system designed for the "user", if that word is a coded pejorative meaning "stupid and unsophisticated". -- Ken Thompson --gKMricLos+KVdGMg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAS0fLmArGtfDbn0QRApe1AJ421Pg/+xlfLgeyN5bdKLhLluN9fgCgzDX9 zLlLcx/Gx9RioCWwwWHS/B4= =QgCR -----END PGP SIGNATURE----- --gKMricLos+KVdGMg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040307160323.GA803>