Date: Sat, 9 Mar 2019 22:14:41 +0100 From: Christoph Moench-Tegeder <cmt@burggraben.net> To: yuri@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r495200 - in head/x11-toolkits/wxgtk30: . files Message-ID: <20190309211441.GA2696@elch.exwg.net> In-Reply-To: <201903092100.x29L0eRg087640@repo.freebsd.org> References: <201903092100.x29L0eRg087640@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yuri, for your attention: ## Christoph Moench-Tegeder (cmt@FreeBSD.org): > URL: https://svnweb.freebsd.org/changeset/ports/495200 > NB: wxgtk31 has similar code in the same place, with some improvements, > but IMO the fix is incomplete (it doesn't account for 11 vs 12). Maintainer > will be notified. Your port x11-toolkits/wxgtk31 has most propably a similar defect. In wxWidget's source, thats in file src/unix/fswatcher_kqueue.cpp , function wxFSWatcherImplKqueue::ProcessNativeEvent(). They sprinkled some l and ll modifiers onto the format specifierts, but that's just half of the story (optimistic estimate). FreeBSD's struct event was changed between 11 and 12 (see https://svnweb.freebsd.org/base?view=revision&revision=320043 and https://www.freebsd.org/doc/en/books/porters-handbook/versions-12.html for that change and __FreeBSD_version (1200033)). And while I'm ranting, what's that about %lp? (I've only one port - cad/kicad - in use depending on wxgtk30, and none depending on wxgtk31, and only jails for anything older than FreeBSD 12, so I'll rather avoid "fixing" other people's ports on a pure gut feeling). Regards, Christoph -- Spare Space
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190309211441.GA2696>