From owner-freebsd-net@FreeBSD.ORG Mon Jan 12 20:47:56 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5309A106564A; Mon, 12 Jan 2009 20:47:56 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-bw0-f20.google.com (mail-bw0-f20.google.com [209.85.218.20]) by mx1.freebsd.org (Postfix) with ESMTP id 426118FC0A; Mon, 12 Jan 2009 20:47:55 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by bwz13 with SMTP id 13so7061116bwz.19 for ; Mon, 12 Jan 2009 12:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=5IDgRy9IcANQeXKOMWOApeSBvkhx7cPZi7tevbg5PSQ=; b=Er0t7BvKx4vz8Flw5bFVecss1UEDjSkSo7ZxJQoX2TAfCSNn61KSBWSvYzmq8FSgvP AkQw5i9lPm3O6AGIHjonoZ9ca6DuHB1cCtoQx1fS7w3ZyneL/DV/UEXf6MAjdmU6ONbR HgJXKKtqwU1e7kiKXUuQ8mBe6pDgqkPcN9Plk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=oMKt2HS0Q1OvnruEPJOmn3LzHSOqTT3Bw+0KuX4dpm33OQ1HF1Y/vDbccYEsVjsfp6 JOH+TF7UTEuGhFzX+7Y18hD5aF5oAHjtsXBgSolUakviJR72vLaxP9G7rTRMl5ORvdKI EF7DTBmkA3GhHMb23rB9argp1MuyWN7Bjp2JU= Received: by 10.181.201.18 with SMTP id d18mr10141900bkq.72.1231793274163; Mon, 12 Jan 2009 12:47:54 -0800 (PST) Received: by 10.181.26.3 with HTTP; Mon, 12 Jan 2009 12:47:54 -0800 (PST) Message-ID: <7d6fde3d0901121247t31ee0d8cp6d46cf9b3b256fad@mail.gmail.com> Date: Mon, 12 Jan 2009 12:47:54 -0800 From: "Garrett Cooper" To: "Julian Elischer" In-Reply-To: <496BAA26.9010200@elischer.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081227202117.F3B14341A3@cavin02.kulnet.kuleuven.ac.be> <200812281613.49404.tijl@ulyssis.org> <7d6fde3d0901121212i3acf282dj6bc3b7d59a044e5e@mail.gmail.com> <496BAA26.9010200@elischer.org> Cc: "Li, Qing" , Gerald Pfeifer , freebsd-net@freebsd.org, Qing Li , freebsd-current@freebsd.org, Tijl Coosemans Subject: Re: HEADSUP: arp-v2 has been committed X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2009 20:47:56 -0000 On Mon, Jan 12, 2009 at 12:37 PM, Julian Elischer wrote: > Garrett Cooper wrote: > > I think setting it to a value of 0 has two good points... > > In code that does: > if (XXX & RTF_LLINFO) { > yyy() > } > the optimiser should simply remove the code, > or at worst give an error messages that makes people go look for > the answer, and secondly, > the conditional > > #if defined(RTF_LLINFO) && (RTF_LLINFO != 0) > > can be easily used to make code conditionally do the right thing > for different versions of freeBSD, > possibly trivially replacing earlier occurances of > > #ifdef RTF_LLINFO > > > >> >> Oh, btw... wine works well when you set the RTF_LLINFO value to 0 >> with arp-v2, AFAICT. >> -Garrett That's basically what I did (2 instances in the file had to be replaced) -- #ifndef RTF_LLINFO /* Insert code here with 0. */ #else /* Insert code here with RTF_LLINFO. */ #endif The code checks to see if sysctl exists, and then defaults to Linux-y behavior, so other OS'es with proper sysctl support could be broken by this change. I tested this out with Steam and wine-doors, but unfortunately I ran into OpenGL issues that prevented me from playing Steam games -_-... Cheers, -Garrett