From owner-svn-src-head@FreeBSD.ORG Sun Dec 2 06:50:27 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DDB1AA4B; Sun, 2 Dec 2012 06:50:27 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id C14A98FC1F; Sun, 2 Dec 2012 06:50:27 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qB26oR9f002530; Sun, 2 Dec 2012 06:50:27 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id qB26oRxT002529; Sun, 2 Dec 2012 06:50:27 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201212020650.qB26oRxT002529@svn.freebsd.org> From: Adrian Chadd Date: Sun, 2 Dec 2012 06:50:27 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r243787 - head/sys/dev/ath X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Dec 2012 06:50:27 -0000 Author: adrian Date: Sun Dec 2 06:50:27 2012 New Revision: 243787 URL: http://svnweb.freebsd.org/changeset/base/243787 Log: Don't grab the PCU lock inside the TX lock. Modified: head/sys/dev/ath/if_ath_tx.c Modified: head/sys/dev/ath/if_ath_tx.c ============================================================================== --- head/sys/dev/ath/if_ath_tx.c Sun Dec 2 06:24:08 2012 (r243786) +++ head/sys/dev/ath/if_ath_tx.c Sun Dec 2 06:50:27 2012 (r243787) @@ -2275,12 +2275,12 @@ ath_raw_xmit(struct ieee80211_node *ni, */ ath_tx_update_tim(sc, ni, 1); + ATH_TX_UNLOCK(sc); + ATH_PCU_LOCK(sc); sc->sc_txstart_cnt--; ATH_PCU_UNLOCK(sc); - ATH_TX_UNLOCK(sc); - return 0; bad2: ATH_KTR(sc, ATH_KTR_TX, 3, "ath_raw_xmit: bad2: m=%p, params=%p, "