From owner-svn-src-head@FreeBSD.ORG Fri Dec 17 15:39:42 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BFD64106566B; Fri, 17 Dec 2010 15:39:42 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119]) by mx1.freebsd.org (Postfix) with ESMTP id 7EAB28FC0C; Fri, 17 Dec 2010 15:39:42 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 3305A582C9; Fri, 17 Dec 2010 09:22:04 -0600 (CST) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from mail.icecube.wisc.edu ([127.0.0.1]) by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id mvNu+7skRGiR; Fri, 17 Dec 2010 09:22:04 -0600 (CST) Received: from comporellon.tachypleus.net (unknown [71.150.248.187]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 8290B582C7; Fri, 17 Dec 2010 09:22:03 -0600 (CST) Message-ID: <4D0B801A.7050608@freebsd.org> Date: Fri, 17 Dec 2010 09:22:02 -0600 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101214 Thunderbird/3.1.7 MIME-Version: 1.0 To: Robert Watson References: <201012160036.oBG0aAEh003539@svn.freebsd.org> <201012161225.31459.jhb@freebsd.org> <20101216175536.GA52462@dragon.NUXI.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216473 - head/sbin/geom/class/eli X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2010 15:39:42 -0000 On 12/16/10 13:04, Robert Watson wrote: > On Thu, 16 Dec 2010, David O'Brien wrote: > >>>> Log: >>>> Bump WARNS to 6. >>>> >>>> Modified: >>>> head/sbin/geom/class/eli/Makefile >>> >>> FYI, this broke the tinderbox on arm, ia64, mips, and sparc64. >> >> Errr. Reverted. I built it on the architectures I had access to... > > For WARNS-related changes, I generally use "make universe" to test > across architectures. This builds all of our architectures world + > all available kernels, and seems the most effective way to avoid the > above situations. (I've fallen into exactly the same trap...) > > The one thing to be cautious about is that make universe won't fail if > an individual build fails, so you need to check the logs to make sure > everything actually succeeded. The trouble with make universe is that it has been broken for months and months now. ARM and powerpc64 are disconnected from the build entirely, as are big-endian and 64-bit MIPS, and an increasing number of ARM and PowerPC kernels depend on FDT tools not built by default, and so do not build. Build infrastructure changes also make it appear that the PowerPC GENERIC64 kernel is broken when it is not. This severely reduces the coverage of make universe for problems like this. I have a patch at http://people.freebsd.org/~nwhitehorn/universe.diff that fixes both of these problems, by teaching the universe rule in src/Makefile about MACHINEs with multiple MACHINE_ARCHs and by enabling the build of the FDT tools by default, which adds about 300K to world. The way these are done is probably not optimal, but it is a better than the current situation and is a good stopgap. With the patch, all architectures succeed except for the ARM AVILA kernel, which seems genuinely broken, and the various 64-bit MIPS kernels, since 64-bit MIPS is not hooked up to the build yet. If I don't hear any objections, I would like to commit it on Wednesday the 22nd. -Nathan