From owner-freebsd-acpi@FreeBSD.ORG Mon Jan 3 04:11:01 2005 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5914816A4CE for ; Mon, 3 Jan 2005 04:11:01 +0000 (GMT) Received: from ylpvm01.prodigy.net (ylpvm01-ext.prodigy.net [207.115.57.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id E542A43D46 for ; Mon, 3 Jan 2005 04:11:00 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.51] (adsl-64-171-186-95.dsl.snfc21.pacbell.net [64.171.186.95])j034AtvE012804; Sun, 2 Jan 2005 23:10:56 -0500 Message-ID: <41D8C5CF.4020606@root.org> Date: Sun, 02 Jan 2005 20:10:55 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041205) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <200501021735.j02HZWAs017587@sana.init-main.com> <41D8B4D2.4050700@root.org> <20050102.210400.71551976.imp@bsdimp.com> In-Reply-To: <20050102.210400.71551976.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: sam@errno.com cc: freebsd-acpi@freebsd.org Subject: Re: ACPI C3 patch for atheros X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2005 04:11:01 -0000 M. Warner Losh wrote: > 0x41 isn't in the standard config space. It ends at 0x3f. Therefore, > it won't have a PCIR_ define, since it is device specific. Ah, didn't notice that. It should have an ATH_PCIR define then. > : It looks like these config writes in ath_pci_attach() should probably be > : done in the PCI bus but they may be driver-specific. The saves of > : config space in ath_pci_suspend/resume() are definitely suspect since we > : save/resume all config space now. See sys/dev/pci/pci.c > > No, we don't. We save only the specific portion of the config space > that we know something about. We also only do the read-write portions > of the config space. Drivers are required to save/restore the device > specific portion of pci config space. Correct, this is a device-specific config register although the others I pointed out (INTLINE, etc.) are standard and are covered by the PCI bus. -- Nate