From owner-svn-src-head@freebsd.org Tue Sep 1 16:44:03 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 614DB3CF10A for ; Tue, 1 Sep 2020 16:44:03 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2k.ore.mailhop.org (outbound2k.ore.mailhop.org [54.148.219.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BgtFG6cnMz3b9B for ; Tue, 1 Sep 2020 16:44:02 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1598978641; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=eT+jSGzpG0q5KHXLK0UZscI8cYIHm0I4ZXsK8XGbwy1s6xYgZhBu+YKoasdaLcZAGjinjjRd9syWC Y4xUw7dAXnSytwe+B8y2P1+Y2Ek4E8rOoq3cnrW6lrXeUA6ORNNjVks37ryR0spSWNRe/tQwEPKeTX r50OTvyNj1trf9G1/KRyXpzlgfUG2ryfRGaRP1EG8kAZbvyO8iYouJaHmN3xQ+yN2W2aLPzHVcB90J s8kOJPjOeQVQTo0g8PknizIL0RQE55V9Tiz9gMOe63uIjTsaH3buqOYJQuulnpJCzums+iQJABaA/E 3eIqHzq5aeo8PPvj9fleHJyqrkqsQGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=j9Uv8S27IsA6N/NS7OUPTmkagLXjdJTOKQGytniHF1I=; b=hHRdjhrundI7EzeSDZ9YfpZjo9OTq14f4iWU01MaA9JXib176/QNeVjxIP0S8Onggf6ZlJ1ZEF5Xu pvcpSXMgtl8qpgQkQls0Gev5pwU+9Xe5D+O98o7s1aXTF1rNy9an7eUcNc+P6GqQXG6bmGc/AUsN8x PLhUt4nFjrno4vEfCF0dJRIWrb+aOE+3+tnPEMDrO2xwu+SUspHTsmJqwHyc0SUDF9hCC0pemibysp bZazdoBOVPjJczaWD/iVciN0bWtoqtcz3DjhpLgCz7/Xv5nNSi/fFdr3qijhSwQPU+QGC0LbQOhh9V 5PIhvP/wUryhn1WrMna7VTqDqdqE1Qg== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=j9Uv8S27IsA6N/NS7OUPTmkagLXjdJTOKQGytniHF1I=; b=ANkGoC+o1XIsvIR+DYyDrz3iznQYU9VhkQ9FmNOjaeFl4/QpfYPny2Txf48lj1ydXkk6U0h+kveB2 CcON+zN2qCxMPLLY9Yn4OfdkNqd9IjMll7rZKkls4DFbNtUoygkfMT338hOU+X65V59r2aYUxB2Kjd BUCag8GGKo0WKvMvMloBDIhdakQ3KiFCy+7l32IV1VzElqgc+iD5gCg99g1ARgsFxnI+yPCtfGtXxB DMpHKUM9LsH05n5I90HpMT1vavX9qxhoWrley6Rt/7+o56e7djYFi/41phUDmvL09UbBSISX78BlOy o+8N5dPHb8OIlD4QYF46OmnGAHp9F4w== X-MHO-RoutePath: aGlwcGll X-MHO-User: 5475bb09-ec72-11ea-9e11-df46ed8f892f X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 5475bb09-ec72-11ea-9e11-df46ed8f892f; Tue, 01 Sep 2020 16:44:00 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 081GhvRA041730; Tue, 1 Sep 2020 10:43:57 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <6f92de5317993ba978276a0fbf8ecff01f73537d.camel@freebsd.org> Subject: Re: svn commit: r365054 - in head/sys: conf dev/sdhci From: Ian Lepore To: Andrew Turner , Marcin Wojtas Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 01 Sep 2020 10:43:57 -0600 In-Reply-To: <874D5323-F0DB-44E9-8779-7C18832A98B4@fubar.geek.nz> References: <202009011617.081GHL8e031671@repo.freebsd.org> <874D5323-F0DB-44E9-8779-7C18832A98B4@fubar.geek.nz> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BgtFG6cnMz3b9B X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 16:44:03 -0000 On Tue, 2020-09-01 at 17:27 +0100, Andrew Turner wrote: > > On 1 Sep 2020, at 17:17, Marcin Wojtas wrote: > > > > Author: mw > > Date: Tue Sep 1 16:17:21 2020 > > New Revision: 365054 > > URL: https://svnweb.freebsd.org/changeset/base/365054 > > > > Log: > > Introduce the SDHCI driver for NXP QorIQ Layerscape SoCs > > > > Implement support for an eSDHC controller found in NXP QorIQ > > Layerscape SoCs. > > > > This driver has been tested with NXP LS1046A and LX2160A > > (Honeycomb board), > > which is incompatible with the existing sdhci_fsl driver (aiming > > at older > > chips from this family). As such, it is not intended as > > replacement for > > the old driver, but rather serves as an improved alternative for > > SoCs that > > support it. > > It comes with support for both PIO and Single DMA modes and > > samples the > > clock from the extres clk API. > > > > Submitted by: Artur Rojek > > Reviewed by: manu, mmel, kibab > > Obtained from: Semihalf > > Sponsored by: Alstom Group > > Differential Revision: https://reviews.freebsd.org/D26153 > > > > Added: > > head/sys/dev/sdhci/sdhci_fsl_fdt.c (contents, props changed) > > Modified: > > head/sys/conf/files > > > > Modified: head/sys/conf/files > > =================================================================== > > =========== > > --- head/sys/conf/files Tue Sep 1 16:13:09 2020 (r365053) > > +++ head/sys/conf/files Tue Sep 1 16:17:21 2020 (r365054) > > @@ -3058,6 +3058,7 @@ dev/scc/scc_dev_z8530.c optiona > > l scc > > dev/sdhci/sdhci.c optional sdhci > > dev/sdhci/sdhci_fdt.c optional sdhci fdt > > dev/sdhci/sdhci_fdt_gpio.c optional sdhci fdt gpio > > +dev/sdhci/sdhci_fsl_fdt.c optional sdhci fdt gpio > > This looks wrong. It should be using an NXP specific option, not > gpio. > > Andrew In addition to gpio, not instead of it (the new driver uses the fdt gpio helper stuff for card detect and write protect). -- Ian