Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Apr 2015 08:13:14 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        marino@freebsd.org
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r383842 - head/graphics/delaboratory
Message-ID:  <20150412081314.GA19302@FreeBSD.org>
In-Reply-To: <552A287F.60003@marino.st>
References:  <201504120802.t3C82LlE042855@svn.freebsd.org> <20150412080655.GA15720@FreeBSD.org> <552A287F.60003@marino.st>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 12, 2015 at 10:10:39AM +0200, John Marino wrote:
> On 4/12/2015 10:06, Alexey Dokuchaev wrote:
> > On Sun, Apr 12, 2015 at 08:02:21AM +0000, John Marino wrote:
> >> New Revision: 383842
> >> URL: https://svnweb.freebsd.org/changeset/ports/383842
> >>
> >> [...]
> >> @@ -21,8 +21,8 @@ WX_UNICODE=	yes
> >>  PLIST_FILES=	bin/${PORTNAME}
> >>  
> >>  post-patch:
> >> -	@${REINPLACE_CMD} -e 's,-Ofast.*},${CXXFLAGS}, ; \
> >> -		s,CXXFLAGS_WX +=,& ${CXXFLAGS} -I${LOCALBASE}/include,' \
> >> +	@${REINPLACE_CMD} -e 's|-Ofast.*}|${CXXFLAGS}| ; \
> >> +		s|CXXFLAGS_WX +=|& ${CXXFLAGS} -I${LOCALBASE}/include|' \
> > 
> > What was wrong with commas?
> 
> CXXFLAGS contained something like "-Wl,-rpath-..." which broken sed.

Ah, I see; indeed.  Given it was not immediately obvious, IMHO it should
have been mentioned in the commit log.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150412081314.GA19302>