From owner-svn-ports-all@FreeBSD.ORG  Sun Apr 12 08:13:14 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 0C4F14C8; Sun, 12 Apr 2015 08:13:14 +0000 (UTC)
Date: Sun, 12 Apr 2015 08:13:14 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: marino@freebsd.org
Subject: Re: svn commit: r383842 - head/graphics/delaboratory
Message-ID: <20150412081314.GA19302@FreeBSD.org>
References: <201504120802.t3C82LlE042855@svn.freebsd.org>
 <20150412080655.GA15720@FreeBSD.org> <552A287F.60003@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <552A287F.60003@marino.st>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Apr 2015 08:13:14 -0000

On Sun, Apr 12, 2015 at 10:10:39AM +0200, John Marino wrote:
> On 4/12/2015 10:06, Alexey Dokuchaev wrote:
> > On Sun, Apr 12, 2015 at 08:02:21AM +0000, John Marino wrote:
> >> New Revision: 383842
> >> URL: https://svnweb.freebsd.org/changeset/ports/383842
> >>
> >> [...]
> >> @@ -21,8 +21,8 @@ WX_UNICODE=	yes
> >>  PLIST_FILES=	bin/${PORTNAME}
> >>  
> >>  post-patch:
> >> -	@${REINPLACE_CMD} -e 's,-Ofast.*},${CXXFLAGS}, ; \
> >> -		s,CXXFLAGS_WX +=,& ${CXXFLAGS} -I${LOCALBASE}/include,' \
> >> +	@${REINPLACE_CMD} -e 's|-Ofast.*}|${CXXFLAGS}| ; \
> >> +		s|CXXFLAGS_WX +=|& ${CXXFLAGS} -I${LOCALBASE}/include|' \
> > 
> > What was wrong with commas?
> 
> CXXFLAGS contained something like "-Wl,-rpath-..." which broken sed.

Ah, I see; indeed.  Given it was not immediately obvious, IMHO it should
have been mentioned in the commit log.

./danfe