Date: Thu, 06 Apr 1995 00:29:27 -0700 From: "Jordan K. Hubbard" <jkh@freefall.cdrom.com> To: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> Cc: jkh@freebsd.org, CVS-commiters@time.cdrom.com, cvs-ports@time.cdrom.com, vode@snakemail.hut.fi Subject: Re: cvs commit: ports/net/sup/patches patch-ae Message-ID: <13542.797153367@freefall.cdrom.com> In-Reply-To: Your message of "Wed, 05 Apr 95 23:34:18 PDT." <199504060634.XAA02561@gndrsh.aac.dev.com>
next in thread | previous in thread | raw e-mail | index | archive | help
It's just _one_ patch file which can easily be moved out of the way or deleted.. Jeeze - I've never seen this much interest in a ports collection item from you before! ;-) If there's enough consensus, I'll happily delete it. Jordan > > > > > No man page updates for it :-(. > > > No way to turn it off :-(. > > > > > > And admitted hackery in the code: > > > + char rfname[1024]; /* Kludge alert.. */ > > > > > > 1. Sorry, I thought he'd changed the manpage. I'll document it if he > > doesn't beat me to it. > > That means you didn't even look at the patch close enough > to know what files where patched. How much of a review could that have > really been :-( > > > 2. You turn it off by not creating a file with the special name.. :-) > > And double the number of stat calls made during the already slow sup :-(. > > > 3. You would prefer that he simply not admit to the hackery? ;-) > > No, I prefer that we not import hackery into our code base. I am not > the only one who is unhappy about these changes. > > > > -- > Rod Grimes rgrimes@gndrsh.aac.dev.com > Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13542.797153367>