Date: Sat, 16 Jul 2022 21:36:03 -0700 From: Devin Teske <dteske@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "Alfonso S. Siciliano" <asiciliano@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, dteske@freebsd.org Subject: Re: git: 6368dcb29228 - main - bsdinstall hostname: Replace dialog with bsddialog Message-ID: <258A0FF7-F770-4574-AA6F-933EC7688C82@freebsd.org> In-Reply-To: <6FF4C58E-A52C-446F-8DB0-C5EE708DBCEB@freebsd.org> References: <6FF4C58E-A52C-446F-8DB0-C5EE708DBCEB@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sent from my iPhone > On 15 Jul 2022, at 12:50 AM, Jessica Clarke <jrtc27@freebsd.org> wrote: >=20 > =EF=BB=BFOn 24 May 2022, at 13:20, Alfonso S. Siciliano <asiciliano@FreeBS= D.org> wrote: >>=20 >> The branch main has been updated by asiciliano: >>=20 >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D6368dcb29228dd8e18d50c54c3= ca1596262d4676 >>=20 >> commit 6368dcb29228dd8e18d50c54c3ca1596262d4676 >> Author: Alfonso S. Siciliano <asiciliano@FreeBSD.org> >> AuthorDate: 2022-05-24 12:04:24 +0000 >> Commit: Alfonso S. Siciliano <asiciliano@FreeBSD.org> >> CommitDate: 2022-05-24 12:20:22 +0000 >>=20 >> bsdinstall hostname: Replace dialog with bsddialog >>=20 >> Replace (LGPL) dialog utility with (BSD-2-Clause) bsddialog utility. >> Add --hline info because bsddialog requires TAB to switch the focus on >> buttons for an inputbox, dialog differs. >=20 > This is quite infuriating and bad UI/UX, everyone knows you can just > type and press enter at these kinds of dialogues, yet bsddialog doesn=E2=80= =99t > support this. Are there any plans to address this shortcoming so > bsddialog can work like every other dialogue box out there and how most > users would expect? This is an unfortunate regression over (LGPL) > dialog and I personally believe bsddialog should have been fixed rather > than introducing this clunky experience to document the flaw. >=20 Not to mention that removing dynamic auto-sizing smacks international users i= n the face because =E2=80=9C0 56=E2=80=9D might look good to your English te= xt but not i18n text. What=E2=80=99s that? This code is not i18n=E2=80=99d? Not yet =E2=80=94 but fixing the size of the box is a step backwards regress= ing away from embracing i18n already patterned by bsdconfig. I observe. =E2=80=94=20 Devin > Jess >=20 >> Delete f_dialog_inputbox_size() using libbsddialog autosizing. >>=20 >> Reviewed by: bapt >> Differential Revision: https://reviews.freebsd.org/D35285 >> --- >> usr.sbin/bsdinstall/scripts/hostname | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >>=20 >> diff --git a/usr.sbin/bsdinstall/scripts/hostname b/usr.sbin/bsdinstall/s= cripts/hostname >> index b151ef15c690..23adbe68ead0 100755 >> --- a/usr.sbin/bsdinstall/scripts/hostname >> +++ b/usr.sbin/bsdinstall/scripts/hostname >> @@ -48,6 +48,8 @@ f_include $BSDCFG_SHARE/dialog.subr >>=20 >> ############################################################ GLOBALS >>=20 >> +: ${BSDDIALOG_CANCEL=3D1} >> + >> # >> # Strings that should be moved to an i18n file and loaded with f_include_= lang() >> # >> @@ -71,21 +73,17 @@ SET_HOSTNAME=3D'hostname -s "%s"' >> dialog_hostname() >> { >> local prompt=3D"$msg_please_choose_a_hostname" >> - local hline=3D >> + local hline=3D"Use TAB and Enter to select $msg_ok" >> local value=3D"$*" >>=20 >> - local height width >> - f_dialog_inputbox_size height width \ >> - "$DIALOG_TITLE" "$DIALOG_BACKTITLE" "$prompt" "$value" "$hline" >> - >> - $DIALOG \ >> + bsddialog \ >> --title "$DIALOG_TITLE" \ >> --backtitle "$DIALOG_BACKTITLE" \ >> --hline "$hline" \ >> --ok-label "$msg_ok" \ >> --no-cancel \ >> --inputbox "$prompt" \ >> - $height $width "$value" \ >> + 0 56 "$value" \ >> 2>&1 >&$DIALOG_TERMINAL_PASSTHRU_FD >> } >>=20 >> @@ -101,7 +99,7 @@ f_dialog_backtitle "$msg_freebsd_installer" >> # Get user input >> # >> HOSTNAME=3D$( dialog_hostname "$HOSTNAME" ) >> -[ $? -eq $DIALOG_CANCEL ] && exit 1 >> +[ $? -eq $BSDDIALOG_CANCEL ] && exit 1 >>=20 >> # >> # Store the user's choice >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?258A0FF7-F770-4574-AA6F-933EC7688C82>