From owner-freebsd-ports@FreeBSD.ORG Sat Oct 6 02:07:50 2012 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id 04444106566C; Sat, 6 Oct 2012 02:07:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [69.147.83.54]) by mx2.freebsd.org (Postfix) with ESMTP id 6ECF514F574; Sat, 6 Oct 2012 02:07:49 +0000 (UTC) Message-ID: <506F9275.3090106@FreeBSD.org> Date: Fri, 05 Oct 2012 19:07:49 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Baptiste Daroussin References: <20121005140534.GB61272@ithaqua.etoilebsd.net> In-Reply-To: <20121005140534.GB61272@ithaqua.etoilebsd.net> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ports@FreeBSD.org Subject: Re: [CHANGE PROPOSAL] Moving WWW from pkg-descr to Makefile X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2012 02:07:50 -0000 On 10/05/2012 07:05 AM, Baptiste Daroussin wrote: > Hi, > > I want to propose and make the actual move of the WWW information from the > pkg-descr to the Makefile itself via a WWW variable. > > doing this will have multiple benefits: > * consistency all metadata bug this one are in Makefile ... except for the distinfo data. > * speedup make describe avoiding using grep to get the informations (make > describe itself does not need speed but make index heavily use it and this > will definitly benefit from speed up) Agreed, but there are other ways to speed up 'make describe,' and tools like ports-mgmt/p5-FreeBSD-Portindex are a much better solution where "create an up to date INDEX quickly" is a real need. > * Third party tool will be able to probe the information more easily. Portmaster doesn't parse WWW for anything, but I have suggested to others in the past that 'while read' in sh is a faster method of finding the WWW than grep. In fact, 'make describe' uses this method now, not grep. I vaguely recall that this was done at my suggestion, but I'm too lazy to trace the commit path to confirm it. :) 'make www-site' (which already exists in case there is a 3rd party tool that needs it) uses a different method utilizing awk. I haven't tested which one is faster. I'm also concerned about the proliferation of things being jammed into the ports Makefile (and coincidentally, bpm). I've noticed that just about every operation that portmaster does using 'make -V' has gotten noticeably slower over the last 6-8 months, and the trend seems to be getting worse instead of better. > Do anyone have any concern about this? For all these reasons, and for the already-stated reason that it severely lowers the value of 'cat pkg-descr' (which I do quite often, and I'm sure other users do as well) I think this is a bad idea. Doug