From owner-svn-src-all@freebsd.org Tue Apr 12 03:30:20 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CCF77B0DE6D; Tue, 12 Apr 2016 03:30:20 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id B6C881BD8; Tue, 12 Apr 2016 03:30:20 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id A8A6615E6; Tue, 12 Apr 2016 03:30:20 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 6DC751FBB8; Tue, 12 Apr 2016 03:30:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 4D8te2ZZgoQi; Tue, 12 Apr 2016 03:30:17 +0000 (UTC) Subject: Re: svn commit: r297836 - head/lib/msun/tests DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 4EC791FBB1 To: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201604112115.u3BLFmN9003703@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <570C6BD4.5030609@FreeBSD.org> Date: Mon, 11 Apr 2016 20:30:28 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <201604112115.u3BLFmN9003703@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IqDDlK8bOBNicBnb2gju6Te6tsmfl6iJL" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2016 03:30:20 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IqDDlK8bOBNicBnb2gju6Te6tsmfl6iJL Content-Type: multipart/mixed; boundary="9wjN0k3dvNHxJi2IfKqc97QkJVFgdcW7b" From: Bryan Drewery To: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <570C6BD4.5030609@FreeBSD.org> Subject: Re: svn commit: r297836 - head/lib/msun/tests References: <201604112115.u3BLFmN9003703@repo.freebsd.org> In-Reply-To: <201604112115.u3BLFmN9003703@repo.freebsd.org> --9wjN0k3dvNHxJi2IfKqc97QkJVFgdcW7b Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/11/2016 2:15 PM, Garrett Cooper wrote: > Author: ngie > Date: Mon Apr 11 21:15:48 2016 > New Revision: 297836 > URL: https://svnweb.freebsd.org/changeset/base/297836 >=20 > Log: > Fix appending -O0 to CFLAGS This seems to be a NOP. > =20 > The previous method would completely nerf CFLAGS once bsd.progs.mk ha= d I'm not seeing 'completely nerf' in a diff: > -/usr/local/bin/ccache cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE = -DLDBL_PREC=3D64 -O0 -g -std=3Diso9899:1999 -fstack-protector-strong -W= no-unknown-pragmas -fcolor-diagnostics -Qunused-arguments -c /root/git= /freebsd/lib/msun/tests/nearbyint_test.c -o nearbyint_test.o > -cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -DLDBL_PREC=3D64 -O0 -= g -std=3Diso9899:1999 -fstack-protector-strong -Wno-unknown-pragmas -fcol= or-diagnostics -Qunused-arguments -o nearbyint_test.full nearbyint_test.= o -lm > +/usr/local/bin/ccache cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE = -O0 -DLDBL_PREC=3D64 -g -std=3Diso9899:1999 -fstack-protector-strong -W= no-unknown-pragmas -fcolor-diagnostics -Qunused-arguments -c /root/git= /freebsd/lib/msun/tests/nearbyint_test.c -o nearbyint_test.o > +cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -O0 -DLDBL_PREC=3D64 -= g -std=3Diso9899:1999 -fstack-protector-strong -Wno-unknown-pragmas -fcol= or-diagnostics -Qunused-arguments -o nearbyint_test.full nearbyint_test.= o -lm It's simply moving it earlier, since it comes before the CFLAGS+=3D-DLDBL= _PREC I diff'd the entire output and all were the same as this. Am I missing something? > recursed into the per-PROG logic and make the CFLAGS for tap testcase= s > to -O0, instead of appending to CFLAGS for all of the tap testcases. > =20 > MFC after: 1 week > Sponsored by: EMC / Isilon Storage Division >=20 > Modified: > head/lib/msun/tests/Makefile >=20 > Modified: head/lib/msun/tests/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/msun/tests/Makefile Mon Apr 11 21:12:24 2016 (r297835) > +++ head/lib/msun/tests/Makefile Mon Apr 11 21:15:48 2016 (r297836) > @@ -62,9 +62,9 @@ TAP_TESTS_C+=3D next_test > TAP_TESTS_C+=3D rem_test > TAP_TESTS_C+=3D trig_test > =20 > -.for t in ${TAP_TESTS_C} > -CFLAGS.$t+=3D -O0 > -.endfor > +.if !empty(PROG) && !empty(TAP_TESTS_C:M${PROG}) > +CFLAGS+=3D -O0 > +.endif > =20 > CSTD=3D c99 > =20 >=20 --=20 Regards, Bryan Drewery --9wjN0k3dvNHxJi2IfKqc97QkJVFgdcW7b-- --IqDDlK8bOBNicBnb2gju6Te6tsmfl6iJL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXDGvUAAoJEDXXcbtuRpfPFjwH/RN55K4eQ5LoITcqB3lf+ZSq DEhP8qwcqZAooazglPylJn5daXstT0/XQRzPyZYSit00igTFU8BF5jtwxnDHaUuE PCzmBUUI3056YwOLSgcRqQ+Hm1rSs3pyGg0nmVvyBpdMYbcLBaKnTwsELZj2NmuS 1TEHx6DnE1DsyB2EAO/59E+q5oCF4dbnJCiRt4LyXVWYBMgl+1wU4A8wL1uGBUPG waFtDdmFBKgDorUG6ddnyN5UOuTtws9CEtnlycMbhYsGTkTCxXktIjSleomksdP+ 0I8fxCH0kCAQHLs+rBS3dvu38iiE+zdQMNq7sU7piMiSfiNS5C1J3ysRIkeJPhU= =Y0dU -----END PGP SIGNATURE----- --IqDDlK8bOBNicBnb2gju6Te6tsmfl6iJL--