From owner-svn-src-head@FreeBSD.ORG Tue Feb 26 19:04:55 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id C51E8D4A; Tue, 26 Feb 2013 19:04:55 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 8ADBE1971; Tue, 26 Feb 2013 19:04:55 +0000 (UTC) Received: from epsilon.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 30ABA24B71; Tue, 26 Feb 2013 11:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1361905495; bh=Yc28KuYhkm0Yqc5QGF0PcqvRGjuwkqFdj6trrVQpRV8=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=RohULJJfMIksDuYSDcq01w3KJu1aj3qmJUmz/tC3vq5W0Il7LoXA8hlrWYJURIzu+ qu5X5xExFDRdSadBEBxCA/WcG33jvu24nB9Wr5PIcPjV0JrB0diFvvdzg21bpsSegR geSJS9a1rBOR/nbW1Jk9k2yD8NOy/VbR0RRBNR6c= Message-ID: <512D0756.80804@delphij.net> Date: Tue, 26 Feb 2013 11:04:54 -0800 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: John Baldwin Subject: Re: svn commit: r247300 - in head: sys/sys usr.bin/truss References: <201302260213.r1Q2D2N1016801@svn.freebsd.org> <201302260941.52534.jhb@freebsd.org> <201302261335.38001.jhb@freebsd.org> In-Reply-To: <201302261335.38001.jhb@freebsd.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Davide Italiano , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: d@delphij.net List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2013 19:04:55 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 02/26/13 10:35, John Baldwin wrote: > On Tuesday, February 26, 2013 12:09:42 pm Davide Italiano wrote: >> On Tue, Feb 26, 2013 at 3:41 PM, John Baldwin >> wrote: >>> On Monday, February 25, 2013 9:13:02 pm Xin LI wrote: >>>> Author: delphij Date: Tue Feb 26 02:13:02 2013 New Revision: >>>> 247300 URL: http://svnweb.freebsd.org/changeset/base/247300 >>>> >>>> Log: Expose timespec and timeval macros when __BSD_VISIBLE is >>>> defined. This allows userland application to use the >>>> following macros: >>>> >>>> timespecclear, timespecisset, timespeccmp, timespecadd, >>>> timespecsub; >>>> >>>> timevalclear, timevalisset, timevalcmp. >>> >>> Why not fix truss to use the stock functions instead of keeping >>> private "unusual" versions? >>> >>> -- John Baldwin >> >> time.h is already a mess in terms of namespace pollution, and >> this exposure might not help thing. Other details here: >> http://permalink.gmane.org/gmane.os.freebsd.architechture/15518 > > I think that is orthogonal. Even if this is reverted I think truss > should be changed to use the "normal" timespecsubt() macro rather > than using a custom one with a different argument order. I'll find a way to solve this and post a patch for review, thanks for your comments. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJRLQdWAAoJEG80Jeu8UPuzpQ0H/1wxy58rK+p/jx2sZtFIhxCA j6H/xQ0nNqthVBW2rw0gwiaUgU1AfcAtdfz7/lFopsvbGFoxzQFYUyC4U67JhSk6 IOgElmtjfFMfvj0ksQnEtIGPMYFbc5G4AHfmmwu4f9cjEPBQz3rPssybGqFvJjO+ tUs7I6tYsq5Lnu9ltjDXgBcNHblgjFqz0jMZ/Rysdu4+51Mga5akyV2D6OFbcbNG oYzC5OOJFvnw6lV+bCVh/ZQNjvEE/Z+YUhfT66MlmU9CBDM9TlYCl7F+5/snZiZ4 0xVFDUIglQqHXkaA1DtP7+HGfVtYhDvO3BgOUe+fHieFxkQFsiEATO4YUImZTKE= =KUVT -----END PGP SIGNATURE-----