From owner-cvs-src@FreeBSD.ORG  Wed Jun 25 11:40:48 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E71F537B405
	for <cvs-src@FreeBSD.org>; Wed, 25 Jun 2003 11:40:47 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 8A0AB44003
	for <cvs-src@FreeBSD.org>; Wed, 25 Jun 2003 11:40:46 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 72800 invoked by uid 1000); 25 Jun 2003 18:40:47 -0000
Date: Wed, 25 Jun 2003 11:40:47 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Olivier Houchard <cognet@FreeBSD.org>
In-Reply-To: <20030625132838.643CB37B415@hub.freebsd.org>
Message-ID: <20030625113931.I72722@root.org>
References: <20030625132838.643CB37B415@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_prot.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jun 2003 18:40:48 -0000

On Wed, 25 Jun 2003, Olivier Houchard wrote:
>   Modified files:
>     sys/kern             kern_prot.c
>   Log:
>   At this point targp will always be NULL, so remove the useless if.
>
>   Revision  Changes    Path
>   1.173     +0 -2      src/sys/kern/kern_prot.c
>
> --- src/sys/kern/kern_prot.c:1.172	Sun Jun 15 08:57:42 2003
> +++ src/sys/kern/kern_prot.c	Wed Jun 25 06:28:32 2003
> @@ -404,8 +404,6 @@
>  	sx_xlock(&proctree_lock);
>  	if (uap->pid != 0 && uap->pid != curp->p_pid) {
>  		if ((targp = pfind(uap->pid)) == NULL) {
> -			if (targp)
> -				PROC_UNLOCK(targp);
>  			error = ESRCH;
>  			goto done;
>  		}

Did you intend to remove the PROC_UNLOCK along with the 'if'?  It seems
it is still needed since at least the proctree_lock is still held.

-Nate