From owner-freebsd-ports@FreeBSD.ORG Sat Aug 31 16:31:45 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A11FFC00 for ; Sat, 31 Aug 2013 16:31:45 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from winston.madpilot.net (winston.madpilot.net [78.47.75.155]) by mx1.freebsd.org (Postfix) with ESMTP id 5E4672A06 for ; Sat, 31 Aug 2013 16:31:45 +0000 (UTC) Received: from winston.madpilot.net (localhost [127.0.0.1]) by winston.madpilot.net (Postfix) with ESMTP id 3cS33h35D7zFTBl; Sat, 31 Aug 2013 18:31:44 +0200 (CEST) X-Virus-Scanned: amavisd-new at madpilot.net Received: from winston.madpilot.net ([127.0.0.1]) by winston.madpilot.net (winston.madpilot.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kk4nYisJlbjX; Sat, 31 Aug 2013 18:31:28 +0200 (CEST) Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206]) by winston.madpilot.net (Postfix) with ESMTPSA; Sat, 31 Aug 2013 18:31:28 +0200 (CEST) Message-ID: <52221A5F.5090800@madpilot.net> Date: Sat, 31 Aug 2013 18:31:27 +0200 From: Guido Falsi User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130809 Thunderbird/17.0.8 MIME-Version: 1.0 To: Boris Samorodov Subject: Re: [kde-freebsd] [patch] x11-toolkits/qt4-gui: configure error: Cups support cannot be enabled due to functionality tests! References: <5221F03A.1000104@passap.ru> <86d2otrimm.fsf@orwell.Elisa> <52221712.1040205@passap.ru> In-Reply-To: <52221712.1040205@passap.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Aug 2013 16:31:45 -0000 On 08/31/13 18:17, Boris Samorodov wrote: > 31.08.2013 19:21, Raphael Kubo da Costa пишет: >> Boris Samorodov writes: >> >>> Hi All, >>> >>> I've examined the following error (486 ports affected): >>> http://pb2.nyi.freebsd.org/bulk/nogcc-default/2013-08-30_22h26m46s/logs/errors/qt4-gui-4.8.4.log >>> >>> ... and it appeared to be a result of latest iconv changes at FreeBSD. >>> >> Are you able to reproduce this error locally? The build error you linked >> to only says building the test file for cups detection failed. Before >> committing the change, I'd like to double-check the exact error message. > > Yes, the error is while running a test to find cups. The test program > fails to build without "-liconv" flag. Here is the log from my testing > system: > http://gw.wart.ru/bulk/10-amd64-default/2013-08-31_00h56m31s/logs/errors/qt4-gui-4.8.4.log > As a stop gap solution this looks ok. My big fear is ending up creating a condition in which some ports link to libc iconv and some to ports iconv, making future fixes even more difficult. The patch I proposed makes cups work with the system iconv without modifying the port. As I said in the PR (ports/181693) most ports already do the right thing and prefer the libc provided iconv if available really. Most ports which are breaking are doing that because they have special directives in the port makefile to force use of the ports iconv. As a side note, I also think that some of those directives are really never necessary, not even on older systems. There are exceptions, obviously. -- Guido Falsi