From owner-freebsd-stable@freebsd.org  Sat Aug 29 14:02:49 2015
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16B6A9C5803
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Sat, 29 Aug 2015 14:02:49 +0000 (UTC)
 (envelope-from boland37@xs4all.nl)
Received: from lb2-smtp-cloud3.xs4all.net (lb2-smtp-cloud3.xs4all.net
 [194.109.24.26])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (Client CN "*.xs4all.nl",
 Issuer "GlobalSign Domain Validation CA - SHA256 - G2" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id A7553E98
 for <freebsd-stable@freebsd.org>; Sat, 29 Aug 2015 14:02:48 +0000 (UTC)
 (envelope-from boland37@xs4all.nl)
Received: from charlemagne.a43.boland.org ([62.194.208.247])
 by smtp-cloud3.xs4all.net with ESMTP
 id Ae2k1r0025LoPm601e2lAw; Sat, 29 Aug 2015 16:02:45 +0200
Subject: Re: Latest stable (r287104) bash leaves zombies on exit
To: Konstantin Belousov <kostikbel@gmail.com>,
 Jilles Tjoelker <jilles@stack.nl>
References: <E1ZUucG-000C5n-0C@dilbert.ingresso.co.uk>
 <63a84f64baf8768a551fc6464e8e9526@mailbox.ijs.si>
 <20150827162602.GJ2072@kib.kiev.ua> <55DF5C95.90502@xs4all.nl>
 <20150827201644.GO2072@kib.kiev.ua> <55DFFADB.2080003@xs4all.nl>
 <20150828100118.GR2072@kib.kiev.ua> <55E083CA.2050705@xs4all.nl>
 <20150828161847.GX2072@kib.kiev.ua> <20150829130138.GA41321@stack.nl>
 <20150829134130.GC2072@kib.kiev.ua>
Cc: Mark Martinec <Mark.Martinec+freebsd@ijs.si>, freebsd-stable@freebsd.org
From: Michiel Boland <boland37@xs4all.nl>
Message-ID: <55E1BB83.4050805@xs4all.nl>
Date: Sat, 29 Aug 2015 16:02:43 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150829134130.GC2072@kib.kiev.ua>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Aug 2015 14:02:49 -0000

On 08/29/2015 15:41, Konstantin Belousov wrote:
> On Sat, Aug 29, 2015 at 03:01:38PM +0200, Jilles Tjoelker wrote:
>> Looks good to me, except that I think a vforked child (in system() and
>> posix_spawn*()) should use the system calls and not libthr's wrappers.
>> This reduces the probability of weird things happening between vfork and
>> exec, and also avoids an unexpected error when
>> posix_spawnattr_setsigdefault()'s mask contains SIGTHR.
>
> Thank you for the review, I agree with the note about vfork. Updated
> patch is below. Also, I removed the PIC_PROLOGUE from the i386 setjmp,
> it has no use after the plt calls are removed.

I verified the patch. The getumask part of lib/libc/gen/setmode.c part was 
rejected on stable/10 (probably due to other changes in ^/head.)

Cheers
Michiel