Date: Sat, 29 Aug 2015 16:02:43 +0200 From: Michiel Boland <boland37@xs4all.nl> To: Konstantin Belousov <kostikbel@gmail.com>, Jilles Tjoelker <jilles@stack.nl> Cc: Mark Martinec <Mark.Martinec+freebsd@ijs.si>, freebsd-stable@freebsd.org Subject: Re: Latest stable (r287104) bash leaves zombies on exit Message-ID: <55E1BB83.4050805@xs4all.nl> In-Reply-To: <20150829134130.GC2072@kib.kiev.ua> References: <E1ZUucG-000C5n-0C@dilbert.ingresso.co.uk> <63a84f64baf8768a551fc6464e8e9526@mailbox.ijs.si> <20150827162602.GJ2072@kib.kiev.ua> <55DF5C95.90502@xs4all.nl> <20150827201644.GO2072@kib.kiev.ua> <55DFFADB.2080003@xs4all.nl> <20150828100118.GR2072@kib.kiev.ua> <55E083CA.2050705@xs4all.nl> <20150828161847.GX2072@kib.kiev.ua> <20150829130138.GA41321@stack.nl> <20150829134130.GC2072@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/29/2015 15:41, Konstantin Belousov wrote: > On Sat, Aug 29, 2015 at 03:01:38PM +0200, Jilles Tjoelker wrote: >> Looks good to me, except that I think a vforked child (in system() and >> posix_spawn*()) should use the system calls and not libthr's wrappers. >> This reduces the probability of weird things happening between vfork and >> exec, and also avoids an unexpected error when >> posix_spawnattr_setsigdefault()'s mask contains SIGTHR. > > Thank you for the review, I agree with the note about vfork. Updated > patch is below. Also, I removed the PIC_PROLOGUE from the i386 setjmp, > it has no use after the plt calls are removed. I verified the patch. The getumask part of lib/libc/gen/setmode.c part was rejected on stable/10 (probably due to other changes in ^/head.) Cheers Michiel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55E1BB83.4050805>