Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Apr 2021 17:46:22 -0400
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Vincenzo Maffione <vmaffione@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 15dc713ceb57 - main - netmap: vtnet: add support for netmap offsets
Message-ID:  <20210407214622.gsedn2cuuj7mblq2@mutt-hbsd>
In-Reply-To: <202104072142.137LgrJC015011@gitrepo.freebsd.org>
References:  <202104072142.137LgrJC015011@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--c75qflhphftjc4ew
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Vincenzo,

On Wed, Apr 07, 2021 at 09:42:53PM +0000, Vincenzo Maffione wrote:
> The branch main has been updated by vmaffione:
>=20
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D15dc713ceb57d0d61c1dc54b1d=
550da42d250730
>=20
> commit 15dc713ceb57d0d61c1dc54b1d550da42d250730
> Author:     Vincenzo Maffione <vmaffione@FreeBSD.org>
> AuthorDate: 2021-04-07 21:32:20 +0000
> Commit:     Vincenzo Maffione <vmaffione@FreeBSD.org>
> CommitDate: 2021-04-07 21:32:20 +0000
>=20
>     netmap: vtnet: add support for netmap offsets
>    =20
>     Follow-up change to a6d768d845c173823785c71bb18b40074e7a8998.
>     This change adds support for netmap offsets.
> ---
>  sys/dev/netmap/if_vtnet_netmap.h | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
>=20
> diff --git a/sys/dev/netmap/if_vtnet_netmap.h b/sys/dev/netmap/if_vtnet_n=
etmap.h
> index a05781255218..a423e71331be 100644
> --- a/sys/dev/netmap/if_vtnet_netmap.h
> +++ b/sys/dev/netmap/if_vtnet_netmap.h
> @@ -84,12 +84,14 @@ vtnet_netmap_txsync(struct netmap_kring *kring, int f=
lags)
>  		for (; nm_i !=3D head; nm_i =3D nm_next(nm_i, lim)) {
>  			/* we use an empty header here */
>  			struct netmap_slot *slot =3D &ring->slot[nm_i];
> +			uint64_t offset =3D nm_get_offset(kring, slot);
>  			u_int len =3D slot->len;
>  			uint64_t paddr;
>  			void *addr =3D PNMB(na, slot, &paddr);
>  			int err;
> =20
> -			NM_CHECK_ADDR_LEN(na, addr, len);
> +			(void)addr;

What is this change for?

Thanks,

--=20
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A=
4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc

--c75qflhphftjc4ew
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBuKCwACgkQ/y5nonf4
4fqgEg/8CrYlJhESq1xULuYK7ejRkNXLyHJuZA7Urto41g8itB7JDB/wbneI9Prt
SUmPDix+mG26MdSHAOF1b3pLRFNqK02fxuToxZAtR3WlyBcEuUDDVFRCF16Ev2u4
FrpJri0YX30r6C/AVIK1qYJnOw/6JQp9ocGkg4g3dYbgPsr6Zr0rbRhSfUoKKG1F
bNBg0mPoRsAjFRL+2P39vSaipiH8l7coWmMScdvy3o85YxmcdiguMOC5X41TAUdi
8F73xn4OaNqd/TW6N12dFuUrok17ePwzaNwiqM1BfChkBb9IofKCC3JtgQCOv9I5
xpSY1gkOYDwHzpOYUOSj43JUwdwXTKvLEmhAiY3+Hi+MWO9cBPXSiHZzSZvEDSYn
GiEP5oVaI50LtETTcIbQrNzMyF9kz81tTF80Mf57lUAyvfwNgLz9ClB9WB8elBY2
jr+QfTRE4OmLLWszq8meWoPmVOA7Vdn6jeHnsXWtsVkgCPvKNf5Vd5YdlhaxH+MW
N+A6axfEmo/xvJJbQX5frYEmPqojuCr2uwX/JOiJQgqpz1hDLqQOP21lGD5CWf8r
EaKBAM4UoDoPVTHDHRdweYOPa5L9earuev4/9cRnfodvaEXNhPX/O21MMKFqf1yG
Rxf2XAj5kwDf3sehXg/prN8WM/bA4W+SeGI0dK2u2Qo8KXtE8k4=
=h+2Y
-----END PGP SIGNATURE-----

--c75qflhphftjc4ew--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210407214622.gsedn2cuuj7mblq2>