From owner-freebsd-current@FreeBSD.ORG  Wed Feb 20 09:56:29 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 818DD16A400;
	Wed, 20 Feb 2008 09:56:29 +0000 (UTC)
	(envelope-from alexander@leidinger.net)
Received: from redbull.bpaserver.net (redbullneu.bpaserver.net
	[213.198.78.217])
	by mx1.freebsd.org (Postfix) with ESMTP id 3C22613C457;
	Wed, 20 Feb 2008 09:56:29 +0000 (UTC)
	(envelope-from alexander@leidinger.net)
Received: from outgoing.leidinger.net (p54A55516.dip.t-dialin.net
	[84.165.85.22])
	by redbull.bpaserver.net (Postfix) with ESMTP id 6024C2E068;
	Wed, 20 Feb 2008 10:56:17 +0100 (CET)
Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102])
	by outgoing.leidinger.net (Postfix) with ESMTP id 5371693C31;
	Wed, 20 Feb 2008 10:56:15 +0100 (CET)
Received: (from www@localhost)
	by webmail.leidinger.net (8.14.2/8.13.8/Submit) id m1K9uECI010729;
	Wed, 20 Feb 2008 10:56:14 +0100 (CET)
	(envelope-from Alexander@Leidinger.net)
Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by
	webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 20 Feb 2008
	10:56:14 +0100
Message-ID: <20080220105614.eydtkfap4gogk0cw@webmail.leidinger.net>
X-Priority: 3 (Normal)
Date: Wed, 20 Feb 2008 10:56:14 +0100
From: Alexander Leidinger <Alexander@Leidinger.net>
To: d@delphij.net, Xin LI <delphij@delphij.net>
References: <47BBD864.3070905@delphij.net>
In-Reply-To: <47BBD864.3070905@delphij.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=UTF-8;
	DelSp="Yes";
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.1.5) / FreeBSD-8.0
X-BPAnet-MailScanner-Information: Please contact the ISP for more information
X-BPAnet-MailScanner: Found to be clean
X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
	score=-14.9, required 6, BAYES_00 -15.00, RDNS_DYNAMIC 0.10)
X-BPAnet-MailScanner-From: alexander@leidinger.net
X-Spam-Status: No
Cc: freebsd-fs@freebsd.org, FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: [PATCH FOR REVIEW] fsck_ffs: Recover from catastrophic damage
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2008 09:56:29 -0000

Quoting Xin LI <delphij@delphij.net> (from Tue, 19 Feb 2008 23:36:04 -0800):

> Change summary:
>
> fsutil.c:
>  - Really update standard superblock.  fsck_ffs -b used to update the
> backup superblock which does not recover file systems which have bad
> master superblocks.
>  - Instead of coredump, zero out whole cg if its signature is bad.
>
> inode.c:
>  - Instead of coredump, zero out whole cg if its signature is bad.

Does this modify (zero out) on-disk blocks? If yes, shouldn't this ask  
for confirmation?

Bye,
Alexander.

-- 
I've been there.

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137