From owner-freebsd-hackers Thu Jul 24 21:31:38 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id VAA13319 for hackers-outgoing; Thu, 24 Jul 1997 21:31:38 -0700 (PDT) Received: from itojun.csl.sony.co.jp (root@itojun.csl.sony.co.jp [133.138.1.134]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA13309 for ; Thu, 24 Jul 1997 21:31:28 -0700 (PDT) From: itojun@itojun.org Received: from localhost (itojun@localhost [127.0.0.1]) by itojun.csl.sony.co.jp (8.8.5/3.3W3) with ESMTP id NAA18565; Fri, 25 Jul 1997 13:30:53 +0900 (JST) To: dg@root.com Cc: hackers@freebsd.org Subject: Re: odd xxget() in some network drivers X-Template-Reply-To: itojun@itojun.org X-Template-Return-Receipt-To: itojun@itojun.org X-PGP-Fingerprint: F8 24 B4 2C 8C 98 57 FD 90 5F B4 60 79 54 16 E2 References: <199707250424.VAA16538@implode.root.com> In-reply-to: David Greenman 's message of Thu, 24 Jul 1997 21:24:54 -0700. <199707250424.VAA16538@implode.root.com> X-Mailer: comp (MHng project) version 1997/04/30 02:23:09, by Jun-ichiro Itoh MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-ID: Date: Fri, 25 Jul 1997 13:30:53 +0900 Message-ID: <18562.869805053@itojun.csl.sony.co.jp> Sender: owner-freebsd-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > The new logic in that PR is: > ! if (MHLEN < len) { > The only problem with the above is that the first if () expression is wrong. >The test should be if (len > MHLEN). Not only is this correct for style, but >it is logically different: MHLEN < len will allocate an mbuf cluster when >len == MHLEN, and this is not desired. ???? I did not write MHLEN <= len. Why len>MHLEN and MHLEN> - could I make some check for other drivers, and apply patches if >> necessery? > I would prefer that you had your proposed changes reviewed first. I prefer that too, however only very few people seems to check problem reports in a regular basis... I do need to wait almost forever. itojun