Date: Fri, 15 Jul 2011 07:15:58 -0600 (MDT) From: Warren Block <wblock@wonkity.com> To: Scot Hetzel <swhetzel@gmail.com> Cc: Stephen Montgomery-Smith <stephen@freebsd.org>, "lioux@FreeBSD.org" <lioux@freebsd.org>, Stephen Montgomery-Smith <stephen@missouri.edu>, pav@freebsd.org, "freebsd-ports@FreeBSD.org" <freebsd-ports@freebsd.org>, "demon@FreeBSD.org" <demon@freebsd.org>, Jung-uk Kim <jkim@freebsd.org> Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2) Message-ID: <alpine.BSF.2.00.1107150646540.52034@wonkity.com> In-Reply-To: <CACdU%2Bf9BJg%2BPPA%2Bwv_Pk0UNYkPfbjHeZ8Hibj5eWLFc3ff8WtA@mail.gmail.com> References: <201107121826.00020.jkim@FreeBSD.org> <201107131857.36772.jkim@FreeBSD.org> <4E1E9C79.6080105@FreeBSD.org> <4E1F200D.1080002@missouri.edu> <1310666060.23182.1.camel@hood.oook.cz> <CACdU%2Bf9BJg%2BPPA%2Bwv_Pk0UNYkPfbjHeZ8Hibj5eWLFc3ff8WtA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---902635197-1328575108-1310735758=:52034 Content-Type: TEXT/PLAIN; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8BIT On Fri, 15 Jul 2011, Scot Hetzel wrote: > 2011/7/14 Pav Lucistnik <pav@freebsd.org>: >> Stephen Montgomery-Smith píše v čt 14. 07. 2011 v 11:57 -0500: >> >>> entry. I assume that the filename of the desktop entry is unimportant, >> >> The filename of desktop entry should be 100% inconsequential, and our >> only care should be not have two ports installing same file. >> >>> and is used only internally by Gnome or whatever. >> >> Sounds like a bug to me. >> >>> But maybe it would have been better to have had one more entry in >>> DESKTOP_ENTRIES that was the actual filename of the desktop entry. >> >> Yes, but is it worth the effort? Note you'll have to introduce it >> somehow not to break existing ports. >> > > How about something like this: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=158936 Wouldn't the point of using a separate filename argument be to let the user specify exactly what the name is? Here you end up with the same system-processed filename. Possibly I've misunderstood. Apart from whether it's necessary, making the filename the last field would simplify the code. Just .if defined(DESKTOP_ENTRIES) or defined(DESKTOP_ENTRIESv2) at the start of parameter processing, and a .if defined(DESKTOP_ENTRIESv2) section after it to override the filename. It could also be made polymorphic, basing what it does on the number of fields rather than a new DESKTOP_ENTRIESv2 define. ---902635197-1328575108-1310735758=:52034--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1107150646540.52034>