From owner-freebsd-ports@FreeBSD.ORG Fri Jul 15 13:16:01 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88BEA106566C; Fri, 15 Jul 2011 13:16:01 +0000 (UTC) (envelope-from wblock@wonkity.com) Received: from wonkity.com (wonkity.com [67.158.26.137]) by mx1.freebsd.org (Postfix) with ESMTP id 208F48FC16; Fri, 15 Jul 2011 13:16:00 +0000 (UTC) Received: from wonkity.com (localhost [127.0.0.1]) by wonkity.com (8.14.5/8.14.5) with ESMTP id p6FDFwND052184; Fri, 15 Jul 2011 07:15:58 -0600 (MDT) (envelope-from wblock@wonkity.com) Received: from localhost (wblock@localhost) by wonkity.com (8.14.5/8.14.5/Submit) with ESMTP id p6FDFw4E052181; Fri, 15 Jul 2011 07:15:58 -0600 (MDT) (envelope-from wblock@wonkity.com) Date: Fri, 15 Jul 2011 07:15:58 -0600 (MDT) From: Warren Block To: Scot Hetzel In-Reply-To: Message-ID: References: <201107121826.00020.jkim@FreeBSD.org> <201107131857.36772.jkim@FreeBSD.org> <4E1E9C79.6080105@FreeBSD.org> <4E1F200D.1080002@missouri.edu> <1310666060.23182.1.camel@hood.oook.cz> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-902635197-1328575108-1310735758=:52034" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (wonkity.com [127.0.0.1]); Fri, 15 Jul 2011 07:15:58 -0600 (MDT) Cc: Stephen Montgomery-Smith , "lioux@FreeBSD.org" , Stephen Montgomery-Smith , pav@freebsd.org, "freebsd-ports@FreeBSD.org" , "demon@FreeBSD.org" , Jung-uk Kim Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2011 13:16:01 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---902635197-1328575108-1310735758=:52034 Content-Type: TEXT/PLAIN; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8BIT On Fri, 15 Jul 2011, Scot Hetzel wrote: > 2011/7/14 Pav Lucistnik : >> Stephen Montgomery-Smith píše v čt 14. 07. 2011 v 11:57 -0500: >> >>> entry.  I assume that the filename of the desktop entry is unimportant, >> >> The filename of desktop entry should be 100% inconsequential, and our >> only care should be not have two ports installing same file. >> >>> and is used only internally by Gnome or whatever. >> >> Sounds like a bug to me. >> >>> But maybe it would have been better to have had one more entry in >>> DESKTOP_ENTRIES that was the actual filename of the desktop entry. >> >> Yes, but is it worth the effort? Note you'll have to introduce it >> somehow not to break existing ports. >> > > How about something like this: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=158936 Wouldn't the point of using a separate filename argument be to let the user specify exactly what the name is? Here you end up with the same system-processed filename. Possibly I've misunderstood. Apart from whether it's necessary, making the filename the last field would simplify the code. Just .if defined(DESKTOP_ENTRIES) or defined(DESKTOP_ENTRIESv2) at the start of parameter processing, and a .if defined(DESKTOP_ENTRIESv2) section after it to override the filename. It could also be made polymorphic, basing what it does on the number of fields rather than a new DESKTOP_ENTRIESv2 define. ---902635197-1328575108-1310735758=:52034--