From owner-freebsd-embedded@FreeBSD.ORG  Tue Jun 16 21:02:16 2009
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: freebsd-embedded@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2E13B106564A;
	Tue, 16 Jun 2009 21:02:16 +0000 (UTC) (envelope-from vwe@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 1E6948FC0C;
	Tue, 16 Jun 2009 21:02:16 +0000 (UTC) (envelope-from vwe@FreeBSD.org)
Received: from freefall.freebsd.org (vwe@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n5GL2GBJ097941;
	Tue, 16 Jun 2009 21:02:16 GMT
	(envelope-from vwe@freefall.freebsd.org)
Received: (from vwe@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n5GL2F9W097937;
	Tue, 16 Jun 2009 21:02:15 GMT (envelope-from vwe)
Date: Tue, 16 Jun 2009 21:02:15 GMT
Message-Id: <200906162102.n5GL2F9W097937@freefall.freebsd.org>
To: vwe@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-embedded@FreeBSD.org
From: vwe@FreeBSD.org
Cc: 
Subject: Re: misc/135588: [nanobsd] simple patch for adding amd64 support
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2009 21:02:16 -0000

Synopsis: [nanobsd] simple patch for adding amd64 support

Responsible-Changed-From-To: freebsd-bugs->freebsd-embedded
Responsible-Changed-By: vwe
Responsible-Changed-When: Tue Jun 16 21:00:32 UTC 2009
Responsible-Changed-Why: 
I hate code duplication. If it's really the same code, there's no need to
copy'n paste. It's much simpler to maintain something like the following
patch.
Over to maintainer(s).

sample replacement patch may look like:

--- nanobsd.sh.orig	2009-06-16 22:56:29.000000000 +0200
+++ nanobsd.sh	2009-06-16 23:00:09.000000000 +0200
@@ -490,6 +490,10 @@
 	) > ${MAKEOBJDIRPREFIX}/_.di 2>&1
 )
 
+create_amd64_diskimage ( ) (
+	create_i386_diskimage $@
+)
+
 last_orders () (
 	# Redefine this function with any last orders you may have
 	# after the build completed, for instance to copy the finished


http://www.freebsd.org/cgi/query-pr.cgi?pr=135588