From owner-p4-projects@FreeBSD.ORG  Wed Sep 21 10:41:47 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6253816A421; Wed, 21 Sep 2005 10:41:47 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3CCE616A41F
	for <perforce@freebsd.org>; Wed, 21 Sep 2005 10:41:47 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DFFEA43D4C
	for <perforce@freebsd.org>; Wed, 21 Sep 2005 10:41:46 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8LAfkoC039980
	for <perforce@freebsd.org>; Wed, 21 Sep 2005 10:41:46 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8LAfk0o039977
	for perforce@freebsd.org; Wed, 21 Sep 2005 10:41:46 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Wed, 21 Sep 2005 10:41:46 GMT
Message-Id: <200509211041.j8LAfk0o039977@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 84041 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Sep 2005 10:41:48 -0000

http://perforce.freebsd.org/chv.cgi?CH=84041

Change 84041 by rwatson@rwatson_zoo on 2005/09/21 10:41:24

	In fstat(), audit the file descriptor rather than the vnode, since
	not all file descriptors have vnodes, and we want to know about the
	object represented by the file descriptor.
	
	Raises interesting questions for things that have vnodes and are
	non-vnodes.  I.e., fifos.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/kern/kern_descrip.c#8 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/kern/kern_descrip.c#8 (text+ko) ====

@@ -1090,8 +1090,7 @@
 	if ((error = fget(td, fd, &fp)) != 0)
 		return (error);
 
-	//XXX Grab the vnode lock?
-	AUDIT_ARG(vnpath, fp->f_vnode, ARG_VNODE1);
+	audit_arg_file(td->td_proc, fp);
 
 	error = fo_stat(fp, sbp, td->td_ucred, td);
 	fdrop(fp, td);