Date: Sat, 7 Jan 2012 12:25:38 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. Message-ID: <20120107112538.GC1696@garage.freebsd.pl> In-Reply-To: <4F079A76.3030306@FreeBSD.org> References: <20120106141301.GE1693@garage.freebsd.pl> <4F079A76.3030306@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Qrgsu6vtpU/OV/zm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote: > On 01/06/2012 06:13, Pawel Jakub Dawidek wrote: > > Any objections? > >=20 > > http://people.freebsd.org/~pjd/patches/set_rcvar.patch > >=20 > > This patch only changes scripts where set_rcvar can be used with no > > arguments. >=20 > Please don't do this. >=20 > Jilles already pointed out the important reason, it adds pointless > forks. I suggested a long time ago that we remove set_rcvar altogether > but I got a lot of resistance to it, and never pursued it. Perhaps it's > time to revisit that. It is a total mess now then and it is definiately not intuitive when there are much more bad examples than good ones: % grep -r ^rcvar /usr/src/etc/rc.d | grep set_rcvar | wc -l 66 % grep -r ^rcvar /usr/src/etc/rc.d | grep -v set_rcvar | wc -l 34 > In regards to your concern about not having to type the name of the > script when copying to create a new one, you can't really be serious > about that? If so, let me introduce you to this revolutionary thing > called "search and replace." Do you really expect me to comment this? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --Qrgsu6vtpU/OV/zm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8IK7EACgkQForvXbEpPzTqTwCcCcKfXAnfbgCCJYkqZzKTEmlY vakAniEZ3Xoduq+14Wwe710WaXlPtBOn =KnoQ -----END PGP SIGNATURE----- --Qrgsu6vtpU/OV/zm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120107112538.GC1696>