From owner-cvs-ports@FreeBSD.ORG Tue Aug 31 17:45:54 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAA3F16A4CE; Tue, 31 Aug 2004 17:45:54 +0000 (GMT) Received: from fillmore.dyndns.org (port-212-202-49-192.dynamic.qsc.de [212.202.49.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70C7B43D45; Tue, 31 Aug 2004 17:45:54 +0000 (GMT) (envelope-from eikemeier@fillmore-labs.com) Received: from dhcp-10.local ([172.16.0.10] helo=dhcp-11.local) by fillmore.dyndns.org with esmtps (TLSv1:DES-CBC3-SHA:168) (Exim 4.42 (FreeBSD)) id 1C2Chb-000Edj-85; Tue, 31 Aug 2004 19:45:53 +0200 Date: Tue, 31 Aug 2004 19:46:10 +0200 Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v482) To: Pav Lucistnik ,, Thierry Thomas From: Oliver Eikemeier In-Reply-To: <200408311457.i7VEvXDO064188@repoman.freebsd.org> Message-Id: Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/pear-Log Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2004 17:45:55 -0000 Pav Lucistnik wrote: > pav 2004-08-31 14:57:33 UTC > > FreeBSD ports repository > > Modified files: > sysutils/pear-Log Makefile > Log: > - Make more customizable using OPTIONS > > PR: ports/71053 > Submitted by: maintainer > > Revision Changes Path > 1.21 +32 -1 ports/sysutils/pear-Log/Makefile This hardcodes LOCALBASE as /usr/local, besides ports should avoid variables beginning with an underscore, since they are often used as bsd.port.mk private variables. Besides, looking at pear-PEAR/Makefile.common is looks like pear ports are inherently not PREFIX safe, or am I wrong here? -Oliver