From owner-freebsd-net@FreeBSD.ORG  Sat Sep 12 19:00:18 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1ACA21065672
	for <freebsd-net@hub.freebsd.org>; Sat, 12 Sep 2009 19:00:18 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 0A68B8FC12
	for <freebsd-net@hub.freebsd.org>; Sat, 12 Sep 2009 19:00:18 +0000 (UTC)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8CJ0Hw9030380
	for <freebsd-net@freefall.freebsd.org>; Sat, 12 Sep 2009 19:00:17 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8CJ0HJu030374;
	Sat, 12 Sep 2009 19:00:17 GMT (envelope-from gnats)
Date: Sat, 12 Sep 2009 19:00:17 GMT
Message-Id: <200909121900.n8CJ0HJu030374@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/138689: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Sep 2009 19:00:18 -0000

The following reply was made to PR kern/138689; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/138689: commit references a PR
Date: Sat, 12 Sep 2009 18:55:27 +0000 (UTC)

 Author: bms
 Date: Sat Sep 12 18:55:15 2009
 New Revision: 197129
 URL: http://svn.freebsd.org/changeset/base/197129
 
 Log:
   Fix an API issue in leave processing for IPv4 multicast groups.
    * Do not assume that the group lookup performed by imo_match_group()
      is valid when ifp is NULL in this case.
    * Instead, return EADDRNOTAVAIL if the ifp cannot be resolved for the
      membership we are being asked to leave.
   
   Caveat user:
    * The way IPv4 multicast memberships are implemented in the inpcb layer
      at the moment, has the side-effect that struct ip_moptions will
      still hold the membership, under the old ifp, until ip_freemoptions()
      is called for the parent inpcb.
    * The underlying issue is: the inpcb layer does not get notification
      of ifp being detached going away in a thread-safe manner.
      This is non-trivial to fix.
   
   But hey, at least the kernel should't panic when you unplug a card.
   
   PR:		138689
   Submitted by:	Stef Walter
   MFC after:	5 days
 
 Modified:
   head/sys/netinet/in_mcast.c
 
 Modified: head/sys/netinet/in_mcast.c
 ==============================================================================
 --- head/sys/netinet/in_mcast.c	Sat Sep 12 18:24:31 2009	(r197128)
 +++ head/sys/netinet/in_mcast.c	Sat Sep 12 18:55:15 2009	(r197129)
 @@ -2189,6 +2189,9 @@ inp_leave_group(struct inpcb *inp, struc
  	if (!IN_MULTICAST(ntohl(gsa->sin.sin_addr.s_addr)))
  		return (EINVAL);
  
 +	if (ifp == NULL)
 +		return (EADDRNOTAVAIL);
 +
  	/*
  	 * Find the membership in the membership array.
  	 */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"