From owner-cvs-all Tue Nov 28 18:14:50 2000 Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 1BF4B37B400; Tue, 28 Nov 2000 18:14:42 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id eAT2Ebo00106; Tue, 28 Nov 2000 18:14:37 -0800 (PST) Date: Tue, 28 Nov 2000 18:14:37 -0800 From: Alfred Perlstein To: "Jeroen C. van Gelderen" Cc: Warner Losh , "Brian F. Feldman" , obrien@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/inetd builtins.c Message-ID: <20001128181437.S8051@fw.wintelcom.net> References: <20001126182240.A8051@fw.wintelcom.net> <200011262140.eAQLe2576200@green.dyndns.org> <20001126182240.A8051@fw.wintelcom.net> <200011280524.WAA07413@harmony.village.org> <20001127221535.Y8051@fw.wintelcom.net> <3A245F2C.9842890E@vangelderen.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3A245F2C.9842890E@vangelderen.org>; from jeroen@vangelderen.org on Tue, Nov 28, 2000 at 09:43:08PM -0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Jeroen C. van Gelderen [001128 17:43] wrote: > Alfred Perlstein wrote: > > > > * Warner Losh [001127 21:24] wrote: > > > > > > Shouldn't this be > > > if (to.tv_usec >= 1000000) { > > > to.tv_sec += to.tv_usec / 1000000; > > > to.tv_usec %= 1000000; > > > } > > > > Yes, but it's overkill as afaik = 2000000 > > shouldn't happen. > > > So, shouldn't it be: > > ASSERT(to.tv_usec < 2000000); > to.tv_usec += tv.tv_usec; > if (to.tv_usec >= 1000000) { > to.tv_usec -= 1000000; > to.tv_sec++; > } > No it should not, but it could. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message