From owner-freebsd-emulation@FreeBSD.ORG Wed Mar 12 10:45:34 2008 Return-Path: Delivered-To: emulation@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C78F106566B for ; Wed, 12 Mar 2008 10:45:34 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from nat-application.b1.lan.prg.vol.cz (nat-application.b1.lan.prg.vol.cz [195.122.204.152]) by mx1.freebsd.org (Postfix) with ESMTP id 6F05E8FC15 for ; Wed, 12 Mar 2008 10:45:33 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from pav.hide.vol.cz (localhost [127.0.0.1]) by nat-application.b1.lan.prg.vol.cz (8.14.2/8.14.2) with ESMTP id m2CAFrQZ052693; Wed, 12 Mar 2008 11:15:53 +0100 (CET) (envelope-from pav@FreeBSD.org) Received: (from pav@localhost) by pav.hide.vol.cz (8.14.2/8.14.2/Submit) id m2CAFrv5052692; Wed, 12 Mar 2008 11:15:53 +0100 (CET) (envelope-from pav@FreeBSD.org) X-Authentication-Warning: pav.hide.vol.cz: pav set sender to pav@FreeBSD.org using -f From: Pav Lucistnik To: Alexander Leidinger In-Reply-To: <20080312110416.rvewfpfrqcgswo0c@webmail.leidinger.net> References: <200803112345.m2BNj4Hj051138@repoman.freebsd.org> <20080312110416.rvewfpfrqcgswo0c@webmail.leidinger.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-YsQhm8BLnJ5c8LCPO/xh" Date: Wed, 12 Mar 2008 11:15:53 +0100 Message-Id: <1205316953.51779.13.camel@pav.hide.vol.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 FreeBSD GNOME Team Port Cc: emulation@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk bsd.port.subdir.mk bsd.xorg.mk X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2008 10:45:34 -0000 --=-YsQhm8BLnJ5c8LCPO/xh Content-Type: text/plain; charset=ISO8859-2 Content-Transfer-Encoding: quoted-printable Alexander Leidinger p=ED=B9e v st 12. 03. 2008 v 11:04 +0100: > Quoting Pav Lucistnik (from Tue, 11 Mar 2008 =20 > 23:45:04 +0000 (UTC)): >=20 > > - Teach USE_LDCONFIG to do the right thing when used with USE_LINUX_P= REFIX > > > > PR: ports/118212 =20 > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D118212 > > Original patch: vd > > Patch by: pav >=20 > I would like to know why emulation@ was not in the loop for this. >=20 > At > http://www.leidinger.net/FreeBSD/port-patches/Mk:bsd.port.mk.diff I wasn't aware of this patch. Is it mentioned in a PR assigned to portmgr anywhere? If I ignore not-ldconfig related changes in your patch, the functionality should be equivalent. I do not need to set NO_LDCONFIG_MTREE, because that code branch is never reached. My code goes like if (linux) { do linux stuff } else { do native stuff } Your code went like if (linux) { setup some variables } else { setup some variables} endif; do { common stuff }. Only difference I see is that you condition the use of linux mdconfig by presence of USE_LINUX, I need USE_LINUX_PREFIX, which is more strict, I think. --=20 Pav Lucistnik Just because you're an angel doesn't mean you have to be a fool. --=-YsQhm8BLnJ5c8LCPO/xh Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEABECAAYFAkfXrVkACgkQntdYP8FOsoKsAACgs0csguqH0LVglhAIfYjQF2+E dtgAnjZZs9A1GN+wW6zQN0fam8wp7znp =ezMQ -----END PGP SIGNATURE----- --=-YsQhm8BLnJ5c8LCPO/xh--