From owner-freebsd-arm@FreeBSD.ORG Mon Sep 22 05:36:40 2008 Return-Path: Delivered-To: arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1CDD106564A; Mon, 22 Sep 2008 05:36:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 5ADAB8FC14; Mon, 22 Sep 2008 05:36:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m8M5ZsxA012765; Sun, 21 Sep 2008 23:35:54 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 21 Sep 2008 23:36:44 -0600 (MDT) Message-Id: <20080921.233644.1649786512.imp@bsdimp.com> To: kevlo@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <1222061003.10402.4.camel@nsl> References: <20080921.202430.-893473872.imp@bsdimp.com> <1222061003.10402.4.camel@nsl> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arm@FreeBSD.org Subject: Re: Code review request X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 05:36:40 -0000 In message: <1222061003.10402.4.camel@nsl> Kevin Lo writes: : M. Warner Losh wrote: : > I did this a long time ago, but never committed it. I believe that : > this works. It uses the common bus space methods to implement the : > default arm bus space methods. : > : > Comments? : : You're missing the bs_ind.h header file and this patch doesn't apply : cleanly against -HEAD. Hmmm.... I'll try again. Sorry about that... Warner