From owner-freebsd-current@FreeBSD.ORG Wed Oct 17 22:26:27 2012 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CEE6ECE5; Wed, 17 Oct 2012 22:26:27 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from micro.madpilot.net (micro.madpilot.net [88.149.173.206]) by mx1.freebsd.org (Postfix) with ESMTP id 64DC08FC0A; Wed, 17 Oct 2012 22:26:27 +0000 (UTC) Received: from micro.madpilot.net (localhost [127.0.0.1]) by micro.madpilot.net (Postfix) with ESMTP id 3Xhnzk0BCCz30W; Thu, 18 Oct 2012 00:26:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= content-transfer-encoding:content-type:content-type:in-reply-to :references:subject:subject:mime-version:user-agent:from:from :date:date:message-id:received:received; s=mail; t=1350512783; x=1352327184; bh=IvTtR8BAj59qMLLzOOHUiV18clQj5NNAPZAd9R5+ckk=; b= K6zayS+WCMzMwkzrBaRRhHoGkbOsqn5ZH+/0z1v7eh/uhyXFK6HQEzp/Sl9ZHp0D sVNrciLxQjqhPscjEDBwraPTL5I0cmoMNp+Jtb8F0mVOXgRJL59up459uXvFYaGQ eSLLRhX7dRlUG36pDw6AomI++TVZ4F3jXfOXLDGGM4Q= X-Virus-Scanned: amavisd-new at madpilot.net Received: from micro.madpilot.net ([127.0.0.1]) by micro.madpilot.net (micro.madpilot.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dIyt_5F2JP5i; Thu, 18 Oct 2012 00:26:23 +0200 (CEST) Received: from marvin.madpilot.net (localhost [127.0.0.1]) by micro.madpilot.net (Postfix) with ESMTP; Thu, 18 Oct 2012 00:26:23 +0200 (CEST) Message-ID: <507F308F.90203@madpilot.net> Date: Thu, 18 Oct 2012 00:26:23 +0200 From: Guido Falsi User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:16.0) Gecko/20121013 Thunderbird/16.0.1 MIME-Version: 1.0 To: Andriy Gapon Subject: Re: Regression with ZFS on recent current References: <507EE9C1.7060800@madpilot.net> <507F1D9E.3010803@FreeBSD.org> <507F26F7.8090302@FreeBSD.org> In-Reply-To: <507F26F7.8090302@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Martin Matuska , "current@FreeBSD.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2012 22:26:27 -0000 On 10/17/12 23:45, Andriy Gapon wrote: > on 18/10/2012 00:05 Andriy Gapon said the following: >> on 17/10/2012 20:24 Guido Falsi said the following: >>> Hi! >>> >>> While testing portshaker I found a regression in latest current. >>> >>> portshaker depends on ZFS(when enabling ZFS support) remounting >>> filesystems on the fly when changing the mountpoint property. This is >>> working as expected on 9.x while on 10-current is not working. Problem >>> has appeared sometime before October 3rd. >> >> Can you clarify what you mean but this date? >> That the problem didn't exist in head until recently? Can you name a date when >> the problem didn't exists in head then? Sorry, I was not clear. I was using -current from October 3rd up to this morning, when I noticed this problem. I tried updating to the latest sources to see if this was already solved by any of the recent commits to zfs. I can't pin down a date when -current was working right away. > > Oh, hmm, not sure if it is a bug that we imported from upstream or a porting > mistake. Before r238391 do_prefix variable in zfs_prop_set (in > cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c) was always initialized. > Now it is either explicitly set to B_FALSE or left alone uninitialized. > > http://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c?r1=237119&r2=238391&pathrev=238391 > I can try reverting this diff and see if it solves the problem. Thanks for pointing out this commit. I'll report back as soon as I have tested this. -- Guido Falsi