From owner-cvs-src@FreeBSD.ORG Thu Jan 29 06:31:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12AE116A4CE; Thu, 29 Jan 2004 06:31:49 -0800 (PST) Received: from phantom.cris.net (phantom.cris.net [212.110.130.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id E66EB43D41; Thu, 29 Jan 2004 06:31:40 -0800 (PST) (envelope-from ru@FreeBSD.org.ua) Received: from phantom.cris.net (ru@localhost [127.0.0.1]) by phantom.cris.net (8.12.10/8.12.10) with ESMTP id i0TEW8em021109; Thu, 29 Jan 2004 16:32:08 +0200 (EET) (envelope-from ru@FreeBSD.org.ua) Received: (from ru@localhost) by phantom.cris.net (8.12.10/8.12.10/Submit) id i0TEW8Ve021108; Thu, 29 Jan 2004 16:32:08 +0200 (EET) (envelope-from ru) Date: Thu, 29 Jan 2004 16:32:08 +0200 From: Ruslan Ermilov To: Guido van Rooij Message-ID: <20040129143208.GH19899@FreeBSD.org.ua> References: <200401291316.i0TDGpbj052050@repoman.freebsd.org> <20040129132732.GB19899@FreeBSD.org.ua> <20040129140955.GX47004@submonkey.net> <20040129142659.GA23750@gvr.gvr.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Az4VpBrmI9+OyhK/" Content-Disposition: inline In-Reply-To: <20040129142659.GA23750@gvr.gvr.org> User-Agent: Mutt/1.5.5.1i cc: Dag-Erling Sm?rgrav cc: Ceri Davies cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2004 14:31:49 -0000 --Az4VpBrmI9+OyhK/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2004 at 03:26:59PM +0100, Guido van Rooij wrote: > On Thu, Jan 29, 2004 at 02:09:55PM +0000, Ceri Davies wrote: > > On Thu, Jan 29, 2004 at 03:07:40PM +0100, Dag-Erling Sm?rgrav wrote: > > > Ruslan Ermilov writes: > > > > Did you mean -u here, because -a is not listed as allowed > > > > in combination with the -o option? > > >=20 > > > no, his patch makes > > >=20 > > > # mount -u -o fstab -a -t ufs > > >=20 > > > work as expected (i.e. restore the fstab flags on all ufs filesystems) > > >=20 > > > previously, > > >=20 > > > # mount -u -o fstab /specific/mount/point > > >=20 > > > would work, but the -a version wouldn't. > >=20 > > The manpage and usage bits should be updated to reflect this. I'm not > > sure, but I think that's what Ruslan was getting at. > >=20 >=20 > I don't get it..it is not specifically mentioned as forbidden. So > it should work.=20 > What Ruslan meant (at least that is how I see it) is that > -o fstab is only mentioned in combination with -u. That is correct. > It still works with -a (without the -u), but specifying it is pointless > as its net effect is nill. So I would not update the manual page. >=20 usage: mount [-dfpruvw] [-o options] [-t ufs | external_type] special node mount [-adfpruvw] [ -F fstab] [-t ufs | external_type] mount [-dfpruvw] special | node Can you see the -a option on the first line with -o? I can't. The fix is to add -a as allowed option to the first line of program's usage() and manpage's SYNOPSIS. Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --Az4VpBrmI9+OyhK/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAGRlnUkv4P6juNwoRAmspAKCCWM7tjxrutpqyU12gQlkuw6pMmwCfeOvm UHqTxP4OuS2yj4ED1tRSmZw= =4wVc -----END PGP SIGNATURE----- --Az4VpBrmI9+OyhK/--